Repository navigation
Deploy Checklist: New Expensify 2024-03-04 #37698
Description
Release Version: 1.4.47-10
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS Migration] Migrate Image to TypeScript #31296
- [TS migration] Migrate 'AddressForm.js' component to TypeScript #34149
- [TS migration] Migrate 'Expensify.js' file to TypeScript #35296
- Handle emoji tooltip #35838
- [No QA][TS migration] Migrate 'react-native-safe-area-context.js' mock to TypeScript #35884
- Fixed LHN Ordering #35907
- [No QA] [TS migration] Migrate 'react-native.js' mock to TypeScript #35908
- Create create-a-company-workspace.md #36192
- [No QA][TS migration] Migrate e2e routes to Typescript #36209
- [No QA] [TS migration] Migrate 'format.js' test to TypeScript #36223
- Styling fixes for ReportPreview/MoneyRequestPreview #36278
- [TS Migration] Migrate 'CategoryPicker' to TypeScript #36353
- [NoQA] [Dashboard] - github action to feed graphite with reassure data #36480
- Refactor/34411 lhn previews followup name for group chat #36591
- Drop domain names when searching for users and auto-filling mentions #36697
- fix: Unable to select members after adding them to the workspace #36713
- [TS migration] Migrate '[Components Group 1]' component to TypeScript #36764
- Update assets for help page #36808
- Update Set-Up-the-Card-for-Your-Company.md #36818
- [TS migration] Migrate ValidationUtilsTest to Typescript #36920
- feat(35600): upgrade electron major versions #36980
- [No QA] [TS migration] Migrate 'installApp.js' test to TypeScript #37004
- [No QA][TS migration] Migrate PusherHelper to Typescript #37026
- [No QA][TS migration] Migrate 'CalendarPickerTest.js' test to TypeScript #37049
- [No QA][TS migration] Migrate 'LocalePhoneNumberTest.js' test to TypeScript #37050
- Fix can't save workspace name using ENTER key after creating a new workspace from workspace switcher page #37069
- FIx downloading video crash #37122
- Fix: User navigates to many pages when quickly press them in ProfilePage #37164
- Track expense/self dm #37165
- Fix - "Concierge" is displayed in LHN and thread header for Concierge approval message #37177
- Update the version of react-navigation/native #37194
- Feature/35713 bulk actions #37199
- Fix sharing video player from chat to attachment modal #37202
- feat: category settings page #37209
- [Simplified Collect][Workflows] Create AutoReporting page and commands #37213
- Always call OpenPublicProfilePage API #37223
- Fix app returns to previous thread when scrubbing video in thread #37270
- [NOQA] Fix Reassure tests for SearchPage #37280
- [TS migration] Migrate 'sleep.js', 'NativeCommandsAction.js', 'wrapOnyxWithWaitForBatchedUpdates.js', 'waitForNetworkPromises.js' and 'waitForBatchedUpdates.js' tests to TypeScript #37304
- Only bold user display name when it's unread in search page #37306
- Remove the side-loading of data in Task action from the ReportActionUtils #37340
- fix(37142): unmount video ref when attachment closes #37386
- [Simplified Collect][Workflows] Select workspace approver #37391
- Fix merchant error is shown in split bill details page while scanning #37393
- Fix display name displays twice on LHN after receiving payment #37398
- [TS migration] Migrate 'ReportTestUtils.js', 'deepReplaceKeysAndValuesTest.js', 'DistanceRequestUtilsTest.js', 'waitForBatchedUpdatesWithAct.js' and 'ConvertToLTRForComposerTest.js' test to TypeScript #37427
- Use theme illustrations for workspace profile #37437
- in recent destinations, bold description if title is not available #37462
- Fix/e2e tests ts issues #37501
- Improve App GH Actions by cancelling some longer tests if a newer run is kicked off, and upgrade to cachev4 #37532
- Fix sign in banner still showing for a moment after login #37584
- Fix: Duplicated waypoints after dragging #37585
- Fix: Current report does not show in LHN under workspace filter #37589
- Add workflow / categories central pane to RHP mapping to correct redirect on reload #37620
- Adding deprecated flag to OptionsSelector #37628
- Update browserify-sign to fix vulnerabilities #37649
- fixes report not showing in search #37653
- Map role 'switch' to button element #37663
- fix wrong visiblity in workspace room settings #37670
- fix: disable engagement modal display for anonymous users #37673
- [NO QA] fix e2e tests: temporarily disable typing test #37677
- [ImgBot] Optimize images #37693
- Delete dupe
src/types/utils/AsMutable.ts, useasMutable#37696 - [CP Staging] #37711 drop down button uses success design on confirmation list #37719
- [CP staging] Fix join button displayed in group chat #37726
- Fix crash when expanding video player #37772
- Revert "Handle emoji tooltip" #37778
- [CP Stag] Fix default autoreportingfrequency #37786
- [CP Staging] Point to the onyx hotfix branch #37804
- [CP Staging] fix: allow make admin in paid workspace only #37808
- Include filtered actions when computing oldest and newest reportAction on a report #37839
- [CP staging] Fix video not opening full screen #37840
Deploy Blockers:
- [HOLD for payment 2024-03-22] [$500] Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu #37289
- [HOLD for payment 2024-03-13] [HOLD for payment 2024-03-11] IOU - Multilevel Tags Dependent are not displayed correctly in the created IOU #37658
- [HOLD for payment 2024-03-14] [$500] Split scan - Scan split request can be created without Merchant #37708
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat #37709
- [HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading #37710
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Split scan - Split button in split menu is gray instead of green #37711
- Android - Attachment - Long images are not displaying correctly in the chat #37725
- BA - User can continue the flow with wrong account number, then error appears on other page #37730
- [PAID] [$500] Chat - Single line code block is hidden if user insert an emoji into it #37738
- Android - Room - User name invited using suggestion is not highlighted #37742
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [$500] Distance - Request details page loads infinitely when the request is created offline #37743
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Chat - Starting a chat with a specific number directs to the "Hmm" page #37746
- Members - 'Make admin' option is not displayed before refreshing the page #37748
- Chat - Emoji tooltip is not translated to Spanish #37749
- [HOLD for payment 2024-03-14] Video - Unable to expand video from video preview modal #37750
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Sign in - User is not navigated to home page when authenticating with magic link #37752
- [$500] Chat - The "Hmm... it's not here" page opens when navigating to the IOU link while logged out #37756
- [HOLD for payment 2024-03-18] [$500] [Simplified Collect][Members] - admin badge is not grayed out when making user admin in offline mode #37757
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here #37758
- [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [Workflows] Workflow - Weekly submission frequency is not selected by default #37764
- [HOLD for payment 2024-04-05] [$500] Category - Recent and All sections appear when selected category is invalid with <8 categories #37766
- [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Workspace - "Free" user is able to see "Admin Role" when WS is made as "Default" #37779
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Mar 4, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.47-0 🚀
rlinoz commentedon Mar 5, 2024
Checking off #37658 as it was CP'd and tested yesterday, just forgot to remove the deploy blocker label.
Julesssss commentedon Mar 5, 2024
Checked off #37756 as it is a bit of an edge case with a simple work around.
luacmartins commentedon Mar 5, 2024
Demoted #37748, feature is still WIP
grgia commentedon Mar 5, 2024
demoted #37757, same as above
kavimuru commentedon Mar 5, 2024
Regression is 10% left in the TR
#36920 - seems does not require QA checking off
#37202 failing with #37710
#37213 failing with #37764
roryabraham commentedon Mar 5, 2024
checked off #37742 because @puneetlath closed it
luacmartins commentedon Mar 5, 2024
Checked off #37766. Can't reproduce, demoted.
roryabraham commentedon Mar 5, 2024
#37749 and #37738 were fixed by #37778. Checking all three of those off
kavimuru commentedon Mar 5, 2024
Regression is 1% left.
#37202 failing with #37710
#37213 failing with #37764
#37584 - blocked in desktop, couldn't anonymously initiate deeplink with #room to open it in desktop (OK to check it off)?
#36278 - #36278 (comment)
PRs yet to be validated:
#36591 - to be validated in android platform
#36764 - to be validated in all the platforms
#37213 - to be validated in desktop
#37585 - to be validated in desktop
#37589 - to be validated in mweb desktop and android
#37620 - to be validated in desktop
#37663 - to be validated in desktop
kavimuru commentedon Mar 5, 2024
Regression is completed.
unchecked PRs:
#37202 failing with #37710
#37213 failing with #37764
#36278 -#36278 (comment)
#37584 - blocked in desktop, couldn't anonymously initiate deeplink with #room to open it in desktop
2 cps and 1 PR #36764 to be validated in all the platforms.
I will post the final summary when all the PRs and Cps are done.
kavimuru commentedon Mar 6, 2024
Regression is completed.
We still have the following PRs to be validated:
#36764 - mWeb, desktop and iOS validations are pending
#37786 - mweb, and native apps validations are pending
4 remaining items
roryabraham commentedon Mar 6, 2024
checking off #37584
roryabraham commentedon Mar 6, 2024
slack threads for summary and action plan: https://expensify.slack.com/archives/C01GTK53T8Q/p1709705296107569
grgia commentedon Mar 6, 2024
Checking off QA for #36278 (added screenshots to PR thread)
kavimuru commentedon Mar 6, 2024
#37758 is fixed in the 1.4.47-7. Checked it off.
kavimuru commentedon Mar 6, 2024
@roryabraham TR is completed.
unchecked PRs:
#37202 failing with #37710
#37213 failing with #37764
#36764 - iOS platform is being validated and other platforms are a pass
Open Blockers:
#37289
#37750
#37752
#37764
#37779
luacmartins commentedon Mar 6, 2024
Checked off #37764. Demoted to NAB since the fix is in Auth/Web-E and it's an UI glitch.
kavimuru commentedon Mar 6, 2024
@roryabraham Regression is completed.
unchecked PRs:
#37202 failing with #37710
#37213 failing with #37764 (can we check it off as per this comment)
Open Blockers:
#37289
#37750
#37752
#37779
roryabraham commentedon Mar 6, 2024
#37289 NAB, checking this off
luacmartins commentedon Mar 6, 2024
Checking off #37779. Tested in staging and it's a pass.
roryabraham commentedon Mar 6, 2024
we just CP'd a fix to the last blocker but it's VERY IMPORTANT we do not ship this checklist yet. We want to include #37839 to fix a fire in production as fast as possible
roryabraham commentedon Mar 6, 2024
CPing #37839 in 1.4.47-10 to fix a fire
roryabraham commentedon Mar 6, 2024
#37202 wasn't directly merged, but is shown as merged because #37840 includes the same commits plus some and was merged. Since #37840 is checked off, I'm also checking off #37202
roryabraham commentedon Mar 6, 2024
verified #37839 on staging on all platforms
roryabraham commentedon Mar 6, 2024