Repository navigation
[HOLD for payment 2024-03-22] [$500] Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu #37289
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:
- User is an employee of paid workspace
- The paid workspace has tags in Parent: Child format
- Go to workspace chat
- Go to + > Split bill > Scan
- Select a receipt
- Click Tag
- Select a tag in Parent: Child format
- Click Split
- Click on the split preview
Expected Result:
The selected Tag in Parent: Child format will be displayed correctly in the split menu
Actual Result:
The selected Tag in Parent: Child format is displayed as Parent: Child in split menu
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6393834_1709031573949.20240227_080353.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01a0f7b9261707ddc4
- Upwork Job ID: 1762476499067256832
- Last Price Increase: 2024-03-06
- Automatic offers:
- dukenv0307 | Contributor | 0
Activity
[-]Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu[/-][+][$500] Tag - Selected tag in Parent: Child format is displayed as Parent\: Child in split menu[/+]melvin-bot commentedon Feb 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a0f7b9261707ddc4
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)github-actions commentedon Feb 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to @iwiznia (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 27, 2024
We think that this bug might be related to #vip-split-p2p-chat-groups
CC @arielgreen
32 remaining items
melvin-bot commentedon Mar 15, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-22. 🎊
For reference, here are some details about the assignees on this issue:
mananjadhav commentedon Mar 22, 2024
We replaced the
PolicyUtils.getCleanedTagName(props.iouTag)here withTransactionUtils.getTag(transaction, index)which caused the issue. I posted this comment.I am not sure if we should be adding a regression test here. @yuwenmemon wdyt? Also can you assign a BZ member here for the payout?
integrate multiple levels of tags to split bill
mananjadhav commentedon Mar 25, 2024
Quick bump @yuwenmemon
melvin-bot commentedon Mar 25, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.JmillsExpensify commentedon Mar 25, 2024
@adelekennedy Can you provide a payment summary and help with payouts please. Thanks!
adelekennedy commentedon Mar 25, 2024
Payouts due:
Contributor: $500 @dukenv0307 (Upwork)
Contributor+: $500 @mananjadhav (NewDot)
Upwork job is here.
JmillsExpensify commentedon Mar 27, 2024
$500 approved for @mananjadhav.