Chat - Emoji tooltip is not translated to Spanish

@bfitzexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Send an emoji only
Change app language to 'Spanish'
Hover over the sent message

Expected Result:

Emoji tooltip should be translated to Spanish

Actual Result:

Emoji tooltip is not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6402592_1709632614313.Screen_Recording_2024-03-05_at_12.31.48_at_night.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@srikarparsi

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@quinthar

We think that this bug might be related to #vip-vsp
CC @quinthar

@srikarparsi

@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Emoji tooltip is not translated to Spanish

What is the root cause of that problem?

We don't pass preferredLocale to EmojiUtils.getEmojiName function.

App/src/components/EmojiWithTooltip/index.tsx

Line 12 in 73e96f7

const emojiName = EmojiUtils.getEmojiName(emoji);

What changes do you think we should make in order to solve the problem?

Use useLocalize to get preferredLocale and pass it to EmojiUtils.getEmojiName function.

PS: getLocalizedEmojiName & getEmojiName both works the same way, we just need to update 'en' | 'es' to Locale.

Result

Offending PR #35838

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji tooltip is not translated to Spanish

What is the root cause of that problem?

We are using getEmojiName, in EmojiWithTooltip:

App/src/components/EmojiWithTooltip/index.tsx

Line 12 in 73e96f7

const emojiName = EmojiUtils.getEmojiName(emoji);

Here we don’t pass We don't pass preferredLocale to getEmojiName

What changes do you think we should make in order to solve the problem?

We should instead use getLocalizedEmojiName:

App/src/libs/EmojiUtils.ts

Lines 52 to 61 in 5199604

    
            * Given an English emoji name, get its localized version 
        
            */ 
        
           const getLocalizedEmojiName = (name: string, lang: OnyxEntry<Locale>): string => { 
        
               if (lang === CONST.LOCALES.DEFAULT) { 
        
                   return name; 
        
               } 
        
               const emojiCode = Emojis.emojiNameTable[name]?.code ?? ''; 
        
               return (lang && Emojis.localeEmojis[lang]?.[emojiCode]?.name) ?? ''; 
        
           };

We already use getLocalizedEmojiName in MiniQuickEmojiReactions.tsx:

App/src/components/Reactions/MiniQuickEmojiReactions.tsx

Line 69 in 5199604

    
           tooltipText={`:${EmojiUtils.getLocalizedEmojiName(emoji.name, preferredLocale)}:`}

What alternative solutions did you explore? (Optional)

N/A

@mkhutornyi

we are looking at reverting #35838 in #37778

@mkhutornyi will retest this issue on that branch

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

should be fixed by #37778 in 1.4.47-3

PR #37778 is reverted and hovering over the emoji does not show any tooltip. This was a new feature.

Recording.1761.mp4

closing this out

Navigation Menu

Repository navigation

Chat - Emoji tooltip is not translated to Spanish #37749

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	* Given an English emoji name, get its localized version
	*/
	const getLocalizedEmojiName = (name: string, lang: OnyxEntry<Locale>): string => {
	if (lang === CONST.LOCALES.DEFAULT) {
	return name;
	}

	const emojiCode = Emojis.emojiNameTable[name]?.code ?? '';
	return (lang && Emojis.localeEmojis[lang]?.[emojiCode]?.name) ?? '';
	};

Chat - Emoji tooltip is not translated to Spanish #37749

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 5, 2024

github-actions commented on Mar 5, 2024

melvin-bot commented on Mar 5, 2024

lanitochka17 commented on Mar 5, 2024

lanitochka17 commented on Mar 5, 2024

Krishna2323 commented on Mar 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

Krishna2323 commented on Mar 5, 2024

allgandalf commented on Mar 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

roryabraham commented on Mar 5, 2024

melvin-bot commented on Mar 5, 2024

roryabraham commented on Mar 5, 2024

kavimuru commented on Mar 5, 2024

roryabraham commented on Mar 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions