Repository navigation
[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat #37709
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.47-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Go to staging.new.expensify.com
- Go to FAB > Start chat.
- Create a group chat.
Expected Result:
Join button will not appear in group chat.
Actual Result:
Join button shows up in group chat header.
The same issue also occurs when User B opens task report created by User A.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Mar 5, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 5, 2024
Triggered auto assignment to @MonilBhavsar (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.m-natarajan commentedon Mar 5, 2024
We think that this bug might be related to #vip-vsb
cc @quinthar
m-natarajan commentedon Mar 5, 2024
@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
nkdengineer commentedon Mar 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
const canJoinOrLeave = isChatThread || !isSelfDM || isUserCreatedPolicyRoom || canLeaveRoomin here to display the join buttonWhat changes do you think we should make in order to solve the problem?
const canJoinOrLeave = (isChatThread || isUserCreatedPolicyRoom || canLeaveRoom) && !isSelfDMinsteadWhat alternative solutions did you explore? (Optional)
!isSelfDMShridharGoel commentedon Mar 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Join button appears in header after creating a group chat.
What is the root cause of that problem?
There is a check
!isSelfDMincanJoinOrLeavebut no way to check if user is already a participant.What changes do you think we should make in order to solve the problem?
A check needs to be added for ensuring that user is not already a participant while creating
canJoin.!ReportUtils.isReportParticipant(currentUserAccountID ?? 0, props.report)11 remaining items
[-]Group chat - Join button appears in header after creating a group chat[/-][+][HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat[/+]melvin-bot commentedon Mar 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 6, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
paultsimura commentedon Mar 6, 2024
No payment here – it was fixed as a regression.
MonilBhavsar commentedon Mar 7, 2024
No payment required. So closing this. Thanks all!
[-][HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat[/-][+][HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Group chat - Join button appears in header after creating a group chat[/+]melvin-bot commentedon Mar 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: