Skip to content

Gb/feature upload media file - #9120

Merged
mzorz merged 67 commits into
developfrom
gb/feature_upload_media_file
Jan 30, 2019
Merged

mzorz merged 67 commits into
developfrom
gb/feature_upload_media_file

Conversation

@marecar3

@marecar3 marecar3 commented Jan 25, 2019 •

Copy link
Copy Markdown
Contributor

Description :
This PR introduces image file upload from Gutenberg which implementation is based on this issue.

This is the first and base iteration of a task that should be implemented. Initial idea is to present an image picker from gutenberg editor which will trigger the upload process when the user picks an image.

Following PR's :
gutenberg-mobile
gutenberg

ezgif com-video-to-gif 1

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

marecar3 and others added 25 commits January 16, 2019 15:12
# Conflicts:
#	libs/gutenberg-mobile
WPAndroid support for media/image upload from Gutenberg
# Conflicts:
#	libs/gutenberg-mobile
# Conflicts:
#	libs/gutenberg-mobile
# Conflicts:
#	libs/gutenberg-mobile
*Upload captured photo
@marecar3
marecar3 requested a review from mzorz January 25, 2019 12:49
@wpmobilebot

wpmobilebot commented Jan 25, 2019 •

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@marecar3 marecar3 added the Gutenberg Editing and display of Gutenberg blocks. label Jan 25, 2019
@mzorz

mzorz commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Added the Not Ready for review label to this one as we're still adding some other work before merge 👍 (working on this with @marecar3 )

@mzorz

mzorz commented Jan 29, 2019 •

Copy link
Copy Markdown
Contributor

As per chat with @marecar3 I've been testing this quite a bit to make sure all of the features we introduced in separate PRs feeding this one were still working correctly.

Apparently uploads work well, reattachment works well, capture photo works well, but choosing an item from media library doesn't do anything.

Issues found while testing:

Let's fix these two then we can merge this.

Also left to do on other set of PRs:

@mzorz

mzorz commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

Crash when selecting multiple images wordpress-mobile/gutenberg-mobile#519

PR addressing it here #9150

@mzorz

mzorz commented Jan 29, 2019 •

Copy link
Copy Markdown
Contributor

choose to upload from media library doesn't do anything wordpress-mobile/gutenberg-mobile#520

PRs addressing this other point here:
wordpress-mobile/gutenberg-mobile#521 and #9151

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM! :shipit:

@mzorz
mzorz merged commit 60d6e6a into develop Jan 30, 2019
@mzorz
mzorz deleted the gb/feature_upload_media_file branch January 30, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants