Skip to content

Passing converted Int mediaId - #9083

Merged
mzorz merged 1 commit into
gb/feature_upload_media_filefrom
gb/fix_media_server_id
Jan 23, 2019
Merged

mzorz merged 1 commit into
gb/feature_upload_media_filefrom
gb/fix_media_server_id

Conversation

@mzorz

@mzorz mzorz commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

This PR just makes sure to pass the converted int for mediaId, and also makes sure to pass mediaFile.getMedaId() upon successful upload.

Related PR wordpress-mobile/gutenberg-mobile#491

To test:

  1. put a breakpoint on private void onUploadSuccess(MediaModel media) { in EditPostActivity
  2. start a GB post and upload an image
  3. wait until it finishes
  4. observe the breakpoint is reached, and look into the media parameter, it should have a mediaId set that is different from its local id. Follow down to the Glue code and observe it's being set correctly in https://github.com/wordpress-mobile/gutenberg-mobile/pull/491/files#diff-f2e1dfe800569dfb4ee4830f88779890R261

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@mzorz mzorz added this to the 11.7 milestone Jan 23, 2019
@mzorz
mzorz requested a review from marecar3 January 23, 2019 21:09

@marecar3 marecar3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved :)

@mzorz
mzorz merged commit 51aa0f4 into gb/feature_upload_media_file Jan 23, 2019
@mzorz
mzorz deleted the gb/fix_media_server_id branch January 23, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants