Repository navigation
Passing converted Int mediaId - #9083
Merged
Merged
Conversation
…on successful upload
marecar3
approved these changes
Jan 23, 2019
marecar3
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Approved :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just makes sure to pass the converted
intformediaId, and also makes sure to passmediaFile.getMedaId()upon successful upload.Related PR wordpress-mobile/gutenberg-mobile#491
To test:
private void onUploadSuccess(MediaModel media) {in EditPostActivitymediaparameter, it should have amediaIdset that is different from its localid. Follow down to the Glue code and observe it's being set correctly in https://github.com/wordpress-mobile/gutenberg-mobile/pull/491/files#diff-f2e1dfe800569dfb4ee4830f88779890R261Update release notes:
RELEASE-NOTES.txt.