Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Feature/upload media file android - #458

Merged
SergioEstevao merged 80 commits into
developfrom
feature/upload_media_file_android
Jan 25, 2019
Merged

SergioEstevao merged 80 commits into
developfrom
feature/upload_media_file_android

Conversation

@marecar3

@marecar3 marecar3 commented Dec 28, 2018 •

Copy link
Copy Markdown
Contributor

Description :
This PR is introducing the logic for exchanging the data between JS side and Android side for purpose of uploading media file.

Test :
It is the part of the WPAndroid PR from which it can be tested.

ezgif com-video-to-gif 1

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is almost good to go, I suggest we change the naming convention and that'd be it most probably.
Once more: nice job @marecar3!


void onMediaLibraryPress(MediaSelectedCallback mediaSelectedCallback);

void onUploadMediaPress(MediaUploadCallback mediaUploadCallback);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should follow the naming convention used in https://github.com/wordpress-mobile/WordPress-Android/pull/8879/files#diff-38b6aea9cfff5f3e0e4b7389b44de602R3185 and have the verb conjugation be in the past tense, i.e. onUploadMediaButtonClicked and onMediaLibraryButtonClicked, following the same pattern of on<EventHappened> as used in interface EditorFragmentListener

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mzorz . Fixed!

SergioEstevao and others added 23 commits January 23, 2019 16:55
…le_ios_part_3

Makes the media id used on uploads an Int.
…captured_photo_android

# Conflicts:
#	react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
…captured_photo_android

# Conflicts:
#	react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
#	react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
# Conflicts:
#	gutenberg
#	ios/gutenberg.xcodeproj/project.pbxproj
#	react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
#	react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m
#	react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift
…captured_photo_android

# Conflicts:
#	gutenberg
…captured_photo_android

# Conflicts:
#	gutenberg
…_photo_android

Feature/upload captured photo android
# Conflicts:
#	bundle/android/App.js
#	bundle/android/App.js.map
#	bundle/ios/App.js
#	bundle/ios/App.js.map
@SergioEstevao
SergioEstevao self-requested a review January 25, 2019 11:56

@SergioEstevao SergioEstevao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, we will use other PR's to implement the error handling and the cancelation.

@SergioEstevao
SergioEstevao merged commit 1a41b8f into develop Jan 25, 2019
@SergioEstevao
SergioEstevao deleted the feature/upload_media_file_android branch January 25, 2019 22:19
@mzorz
mzorz restored the feature/upload_media_file_android branch January 25, 2019 22:27
@mzorz

mzorz commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@SergioEstevao please wait before merging - I was going to open a PR against this one. Will do against develop now, but please wait a bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants