Repository navigation
Fix #19344 - Use a single class name for opened/expanded/shown state of widgets - #20982
Conversation
There was a problem hiding this comment.
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
|
😻 (Woof, we gotta fix Hound. I know we have to either rewrite those tests or do something else, but maybe there's a fix for Hound itself or another JS validator?) |
|
I read a bit on HoundCi and I didn't found any options to lint differently JavaScript from About my PR, I have to change exemples in the documentation and visual tests |
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 10 indent
|
Everything is done @mdo 💪 |
|
This. Is. AWESOME. You're a champ! |
|
One thing I didn't think about was the differences between |
Use only
.activewhen a widget is opened/expanded/shownTODO :
PR in progressClose : #19344