Skip to content

Fix #19344 - Use a single class name for opened/expanded/shown state of widgets - #20982

Merged
mdo merged 1 commit into
twbs:v4-devfrom
Johann-S:fix19344
Oct 26, 2016
Merged

mdo merged 1 commit into
twbs:v4-devfrom
Johann-S:fix19344

Conversation

@Johann-S

@Johann-S Johann-S commented Oct 24, 2016 •

Copy link
Copy Markdown
Member

Use only .active when a widget is opened/expanded/shown

TODO :

  • Alert
  • Collapse
  • Dropdown
  • Modal
  • Popover
  • Tooltips
  • Documentation
  • Visual tests

PR in progress

Close : #19344

Comment thread js/tests/unit/tooltip.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Expected '===' and instead saw '==' eqeqeq

Comment thread js/tests/unit/tooltip.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected '===' and instead saw '==' eqeqeq

Comment thread js/tests/unit/alert.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var

Comment thread js/tests/unit/alert.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/dropdown.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback

Comment thread js/tests/unit/collapse.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var

@mdo

mdo commented Oct 25, 2016

Copy link
Copy Markdown
Member

😻

(Woof, we gotta fix Hound. I know we have to either rewrite those tests or do something else, but maybe there's a fix for Hound itself or another JS validator?)

@mdo mdo added js JavaScript or TypeScript sources and plugins v4 v4, the frozen docs on gh-pages labels Oct 25, 2016
@Johann-S

Johann-S commented Oct 25, 2016 •

Copy link
Copy Markdown
Member Author

I read a bit on HoundCi and I didn't found any options to lint differently JavaScript from js/tests/ folder unless to ignore them with .eslintignore see :
https://houndci.com/configuration#eslint
http://eslint.org/docs/user-guide/command-line-interface#ignoring-files-from-linting

About my PR, I have to change exemples in the documentation and visual tests

Comment thread js/tests/unit/collapse.js Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 6 space characters but found 10 indent

@Johann-S

Copy link
Copy Markdown
Member Author

Everything is done @mdo 💪

@mdo mdo modified the milestone: v4.0.0-alpha.6 Oct 26, 2016
@mdo

mdo commented Oct 26, 2016

Copy link
Copy Markdown
Member

This. Is. AWESOME. You're a champ!

@mdo
mdo merged commit aa11f00 into twbs:v4-dev Oct 26, 2016
@mdo mdo mentioned this pull request Oct 26, 2016
@mdo

mdo commented Oct 27, 2016

Copy link
Copy Markdown
Member

One thing I didn't think about was the differences between .open and .active for selected nav links. If a dropdown link in a nav is active, it might not necessarily open as well. I might have to change that state to .selected or something similar.

twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this pull request Oct 28, 2016
@Starsam80 Starsam80 mentioned this pull request Nov 28, 2016
7 tasks done
@Johann-S
Johann-S deleted the fix19344 branch March 30, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

js JavaScript or TypeScript sources and plugins v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants