Repository navigation
Rename .active to .show - #21036
Rename .active to .show#21036
.active to .show#21036Conversation
There was a problem hiding this comment.
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 10 indent
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
|
I think this will run into similar issues as the |
|
Just tried it, and all it does is add |
|
Ah, it looks like the jQuery |
There was a problem hiding this comment.
Think of .show as it "showing" the fade animation, while .active is the one that is currently selected.
mdo
added
js
|
Right now in dev branch I see that fade animation has now So what class name is going to be used instead of Same question about P.S. talking about selected (active) states, may be, it is better to use |
As far as I know, the |
There was a problem hiding this comment.
Statement inside of curly braces should be on next line brace-style
Closing curly brace should be on the same line as opening curly brace or on the line after the previous block brace-style
This line has 2 statements. Maximum allowed is 1 max-statements-per-line
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
Expected '===' and instead saw '==' eqeqeq
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
'QUnit' is not defined no-undef
Unexpected function expression prefer-arrow-callback
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
Expected indentation of 6 space characters but found 10 indent
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
|
I change 1 line and hound blows up. That really needs to be fixed. |
|
@Starsam80 that is being worked on. |
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
All 'var' declarations must be at the top of the function scope vars-on-top
There was a problem hiding this comment.
All 'var' declarations must be at the top of the function scope vars-on-top
Unexpected var, use let or const instead no-var
There was a problem hiding this comment.
All 'var' declarations must be at the top of the function scope vars-on-top
Unexpected var, use let or const instead no-var
|
I think Collapse should be .in, popover .show and collapse .active if we want a certain logic and it will correct the conflict!! |
|
@TheBuzzer67 Wait you mean the "Conflicting files"? I can fix that anytime, but when I do, hound will probably blow up again. EDIT: Huh, it didn't this time. I will never understand how it works. |
7 participants
Fixes #21021.
Also fixes tabs by changing
.into.show