Repository navigation
Use a single class name for opened/expanded/shown state of widgets? #19344
Description
Refs #19254 (comment)
- I don't know of any particular good reason why we currently use multiple different classes for this. Seems to just be an accident of history.
- Using a single name would make things more uniform in general
- Using a single name would make reimplementing Bootstrap's JS in $JS_FRAMEWORK_OF_THE_HOUR slightly easier
Activity
cvrebert commentedon Mar 14, 2016
@mdo @XhmikosR SGTY?
XhmikosR commentedon Mar 14, 2016
I'm not quite sure I understand the suggestion. Can you share an example of how this would be?
cvrebert commentedon Mar 14, 2016
Currently, we toggle the
.openclass on.dropdown-menuto open/close a dropdown menu, we toggle the.activeclass on.tab-paneto show/hide a tab pane, and we toggle the.inclass on.collapseto (un)collapse a collapsible widget. (And likewise for other widgets.)The suggestion is to use one class name (e.g.
.active) instead of different ones (.open,.active,.in) in all these cases. So you'd always toggle.activeto (de)activate a widget, regardless of which widget it is.Basically we'd globally find-replace
.open,.active, and.inwith.active(or whatever single name we end up agreeing on).XhmikosR commentedon Mar 14, 2016
Seems, simpler indeed, but what is the caveat? Or it's like that from the old days?
cvrebert commentedon Mar 14, 2016
AFAICT, old days.
XhmikosR commentedon Mar 14, 2016
Then, I don't see any reason not to do this. It's clearly simpler.
mdo commentedon Oct 24, 2016
I'm down for this. I'm thinking
.activecould work well for everything?Merge pull request twbs#20982 from Johann-S/fix19344