Skip to content

fix(i18n): cover the native chat font family setting strings - #33716

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/main-fix-chat-font-i18n
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/main-fix-chat-font-i18n

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​25 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​24
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​24 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​23

Follow-up to #33687.

The custom chat font setting added five untranslated search keywords and a literal code sample. The localization coverage check then failed on main and on PRs that incorporated it.

Use the existing localized search-keyword helper and catalog entries so translated terms and English aliases both find the setting. Add one exact exclusion for fontFamily, the code identifier in the font preview. The coverage script supports reviewed exclusions for non-translatable literals; the existing allowlist uses the same convention for literal names. No human-language search terms are excluded. The setting and preview look and behave as before, with translated search text available.

Plan: reuse existing translations and the coverage allowlist, and verify localized search after switching languages. No new localization mechanism or saved setting changes.

Light-path classification:

  • Small: one production TypeScript file, under 20 changed production lines; one allowlist entry and one renderer regression test.
  • Outside risky areas: only search text and a coverage exclusion change; no saved settings, lifecycle, IPC, defaults, or ownership changes.
  • Not a repeat: the last 30 days of history for the failing files contains their feature additions and no earlier localization-coverage fix or revert.
  • Local effect: localized Settings search terms; the displayed font preview is unchanged.

Validation: added a renderer regression for Korean synonyms and English aliases after a language switch, plus unchanged fontFamily preview text. The local coverage invocation could not start because this fresh worktree has no dependencies (typescript-api missing); CI provides the coverage check and renderer tests. No running-app QA or screenshot is needed because screen appearance and saved settings are unchanged.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate: #33711 already repairs the same localization-coverage break from #33687 (allowlist plus localized search keywords), and #33710 is a second open fix. Tracked in #33711.

@brennanb2025
brennanb2025 deleted the brennanb2025/main-fix-chat-font-i18n branch October 26, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant