Repository navigation
fix(i18n): cover the native chat font family setting strings - #33716
Closed
brennanb2025 wants to merge 1 commit into
Closed
brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33687.
The custom chat font setting added five untranslated search keywords and a literal code sample. The localization coverage check then failed on main and on PRs that incorporated it.
Use the existing localized search-keyword helper and catalog entries so translated terms and English aliases both find the setting. Add one exact exclusion for
fontFamily, the code identifier in the font preview. The coverage script supports reviewed exclusions for non-translatable literals; the existing allowlist uses the same convention for literal names. No human-language search terms are excluded. The setting and preview look and behave as before, with translated search text available.Plan: reuse existing translations and the coverage allowlist, and verify localized search after switching languages. No new localization mechanism or saved setting changes.
Light-path classification:
Validation: added a renderer regression for Korean synonyms and English aliases after a language switch, plus unchanged
fontFamilypreview text. The local coverage invocation could not start because this fresh worktree has no dependencies (typescript-apimissing); CI provides the coverage check and renderer tests. No running-app QA or screenshot is needed because screen appearance and saved settings are unchanged.