Repository navigation
[comment audit] Complete repository-wide comment cleanup - #33249
Merged
Merged
Conversation
…ry comments [skip ci]
…ationale [skip ci]
… comments [skip ci]
|
Found 10 test failures on Blacksmith runners: Failures
|
8 tasks done
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
main's comment cleanup (stablyai#33249) shortened the header of plugin-chrome-allowlist.test.ts to one line, and this branch extended the same header for its per-component count test. The header keeps main's one line, now naming the third check. No code changed.
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment cleanup (stablyai#33249) applied that across the repository. This brings the comments this branch adds in line with it. No code changes.
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
main's comment cleanup (stablyai#33249) shortened the comment above pluginLocaleIdSchema to one line, next to the isWellFormedLocaleId helper this branch adds. The helper and the schema refine are kept as they were; the comment takes main's line plus one line for why Intl checks the grammar.
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment cleanup (stablyai#33249) applied that across the repository. This brings the comments this branch adds in line with it. No code changes.
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
main's comment cleanup (stablyai#33249) reworded a comment inside the inline commitSyncTitle ladder, which this branch moves into source-control-dropdown-copy.ts. The branch's call to the moved function is kept, and the moved comment takes main's wording. No code changed on main's side of the conflict.
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment cleanup (stablyai#33249) applied that across the repository. This brings the comments this branch adds in line with it. No code changes.
2 tasks done
DoozyX
added a commit
to DoozyX/orca
that referenced
this pull request
Oct 26, 2026
Merge stablyai/orca main b759a95 into fork main 83fb74d. 66 conflicts, mostly upstream's repo-wide comment audit (stablyai#33249): fork code kept with upstream comments. Code-level combinations: mailbox pointer delivery (stablyai#33639) with the fork's queued/injected outcome; held-batch lookup spans every outstanding typed delivery (fork schema v44); launched-agent write guard keeps the fork settle loop plus upstream's write-if-shell-provable policy; worker-start keeps the fork's refusal to guess the coordinator (upstream test adapted); monitored-work rows stay out of Claude agent view. Files over max-lines are split without behavior change (group settings dialog gets its own hook).
This was referenced Oct 26, 2026
3 of 5 tasks
This was referenced Oct 26, 2026
This was referenced Oct 26, 2026
Draft
jinho-yoo-jack
added a commit
to jinho-yoo-jack/orca
that referenced
this pull request
Oct 27, 2026
Brings the branch up to upstream 7782fd5. Resolves two conflicts: - TabGroupSplitNodeTree.tsx: keep the grid view's isWorktreeFocused gate and adopt the one-line comment from upstream's comment cleanup (stablyai#33249). - en.json: keep upstream's new ClaudeAgentViewIndicator keys alongside the grid view keys; sync:localization-catalog reports no further changes. store/index.ts, store/types.ts, store-test-helpers.ts and wsl-move-storage-dispositions.ts merged cleanly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OrcaWin
added a commit
that referenced
this pull request
Oct 27, 2026
* fix(plugins): reject locale ids Intl cannot parse `pluginLocaleIdSchema` checks the shape of a locale id but not its grammar, and the shape check is looser than BCP 47 in one direction: `en-US-US` (duplicate region) and `en-aaa` (a subtag that is neither region nor script) both match it. A pack declaring one installs, loads, and translates every string — and then `Intl.DateTimeFormat` throws inside `getIntlLocale()`, which swallows the error and falls back to English. Nothing is logged, so the pack author sees a working pack with English dates and no way to tell why. Delegate the grammar to `Intl.getCanonicalLocales` in a `.refine`, so the tag is rejected at install where the author can still act on it. The bundled `pt-BR` pack and every other well-formed tag are unaffected. * Condense this branch's comments to one line AGENTS.md asks for one-line comments that say why, and main's comment cleanup (#33249) applied that across the repository. This brings the comments this branch adds in line with it. No code changes. --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
9 tasks done
7 tasks done
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
ELI5
Remove comments that repeat the code and shorten useful explanations. Keep the reasons behind security, ownership, platform and compatibility decisions.
What Changed
Complete the review of 37,524/37,524 source/configuration files, reconciled with main
a5e948dc3de. The diff changes 16,196 files and removes 128,867 net lines. Prose docs, binaries and data-only JSON are outside the inventory; generated/vendor ownership boundaries remain intact.Preserve licenses, tool directives, SAFETY explanations and useful incident references. Verify executable equivalence across comment edits and upstream reconciliation. The tracker, scripts and verification artifacts stay outside the repository.
Supporting CI/test maintenance:
Consolidates #33011 and #33136, both closed. No application behavior changes are introduced by the audit.
Why
Finish the repository-wide audit in one merge, validating combined corrections locally before publication to reduce CI runs.
Visual Proof
N/A — no application behavior or design changes.
Testing
pnpm check:changed --maxWorkers=2incremental gates: 36/36, then 27/27 checks passed. Latest broad selection: 4,212 passed files, 19 skipped, zero unhandled errors. Terminal fixture cleanup passed all 21 affected checks and its delayed-import reproduction.ORCA_BACKGROUND_LAUNCH=1and private Xvfb displays.Linux validation supplies Node 24, shell tools and isolated prompt profiles. Windows, macOS and the remaining native-focus checks are CI validation. Merge requires all final-head required checks and the PR checks passed aggregate.
Agent skill upstream boundary