Skip to content

[comment audit] Complete repository-wide comment cleanup - #33249

Merged
OrcaWin merged 403 commits into
mainfrom
OrcaWin/comment-audit-consolidated-531
Oct 25, 2026
Merged

OrcaWin merged 403 commits into
mainfrom
OrcaWin/comment-audit-consolidated-531

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 882 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2850 $\color{#cf222e}{\Huge{\mathbf{−}}}$​11981 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9131
Prod 2118 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​7591 $\color{#cf222e}{\Huge{\mathbf{−}}}$​33177 $\color{#cf222e}{\Huge{\mathbf{−}}}$​25586

ELI5

Remove comments that repeat the code and shorten useful explanations. Keep the reasons behind security, ownership, platform and compatibility decisions.

What Changed

Complete the review of 37,524/37,524 source/configuration files, reconciled with main a5e948dc3de. The diff changes 16,196 files and removes 128,867 net lines. Prose docs, binaries and data-only JSON are outside the inventory; generated/vendor ownership boundaries remain intact.

Preserve licenses, tool directives, SAFETY explanations and useful incident references. Verify executable equivalence across comment edits and upstream reconciliation. The tracker, scripts and verification artifacts stay outside the repository.

Supporting CI/test maintenance:

  • Retain the two validated Ubuntu 22.04 IME runner-label repairs; reduce text-count and flaky-pattern allowances where findings decreased.
  • Increase bounded audit-report capture from 8 to 64 MiB, with a real subprocess regression for reports above the old limit.
  • Reuse timing-based E2E distribution for broad changed-spec selections, bounded at 14 shards. Native discovery verifies all 689 selected tests occur exactly once; older dispatched refs retain their native fallback.
  • Refresh selected existing E2E expectations, selectors and probes for current upstream behavior, retaining behavioral assertions and existing convergence checks.
  • Cancel pending terminal fit continuations during fixture teardown. A delayed-import reproduction confirmed retries from earlier tests contaminated later frame queues; cleanup preserves the original assertions and fixes that failure.

Consolidates #33011 and #33136, both closed. No application behavior changes are introduced by the audit.

Why

Finish the repository-wide audit in one merge, validating combined corrections locally before publication to reduce CI runs.

Visual Proof

N/A — no application behavior or design changes.

Testing

  • pnpm check:changed --maxWorkers=2 incremental gates: 36/36, then 27/27 checks passed. Latest broad selection: 4,212 passed files, 19 skipped, zero unhandled errors. Terminal fixture cleanup passed all 21 affected checks and its delayed-import reproduction.
  • Final upstream integration: 948 root tests passed across 35 files, three Windows-only skips; 144 mobile tests passed across 13 files. Full root and mobile production/test types pass; changed-code quality reports zero findings across 49 files. All 30 selected repository script guards and the dead design-system class lint pass.
  • Subsequent backend integration: 79 root tests and 21 mobile tests pass; full root types and changed quality across 17 files pass.
  • Full mobile CI Node/Bun selection: 11,310 passed, six skipped. Final production types and 1,110 test files pass with zero grandfathered type errors.
  • Real React Doctor changed-lines gate: 0 errors, with the large report captured successfully.
  • Source/emitted AST and executable-token proofs cover the comment-edited JS/TS files, with incremental reconciliation proofs and protected-comment checks. Latest integrations: 38, then 14 source/emitted/token and protected overlaps pass after commit hooks; the earlier native Rust noncomment proof also passes.
  • Noncomment equivalence also covers 79 other-language files, eight stylesheets, 30 YAML files / 44 embedded scripts, and the generated Bash fixture. New AST-grep lint and 11 rule-test groups pass; baseline changes only reduce allowances.
  • Broad local E2E: 689 cases, with targeted reruns accounting for every initial failure. Corrected selected tests and shell-sensitive cases pass; nine native-focus/foreground-timing cases require CI. Launches use ORCA_BACKGROUND_LAUNCH=1 and private Xvfb displays.

Linux validation supplies Node 24, shell tools and isolated prompt profiles. Windows, macOS and the remaining native-focus checks are CI validation. Merge requires all final-head required checks and the PR checks passed aggregate.

Agent skill upstream boundary

  • Not applicable; no upstream skill-installer source is copied or translated.

@OrcaWin
OrcaWin merged commit 7d6603a into main Oct 25, 2026
108 of 112 checks passed
@blacksmith-sh

blacksmith-sh Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Found 10 test failures on Blacksmith runners:

Failures

Test View Logs
[electron-headful] › tests/e2e/
pr11346-selected-runtime-add.spec.ts:751:5 › routes every Add Project path to a selecte
d non-default headed runtime @headful
View Logs
[electron-headless] › tests/e2e/
diff-note-line-range.spec.ts:269:7 › Diff note line range › dragging from the "+" itsel
f selects a range and the button rides the selection
View Logs
[electron-headless] › tests/e2e/
pr11346-selected-runtime-add.spec.ts:759:5 › keeps every selected-runtime Add Project p
ath in hidden-window desktop parity
View Logs
[electron-headless] › tests/e2e/
ssh-orcad-explorer-watch-recovery.spec.ts:28:7 › remote folder explorer receives host-c
reated files after server restart
View Logs
[electron-headless] › tests/e2e/
structured-chat-tabs-open-close.spec.ts:60:7 › structured chat tabs › open from the hos
t and the New tab menu, show in the tab bar, and close
View Logs
Diff note line range/
dragging from the "+" itself selects a range and the button rides the selection
View Logs
structured chat tabs/
open from the host and the New tab menu, show in the tab bar, and close
View Logs
tests/e2e/pr11346-selected-runtime-add.spec.ts/
keeps every selected-runtime Add Project path in hidden-window desktop parity
View Logs
tests/e2e/pr11346-selected-runtime-add.spec.ts/
routes every Add Project path to a selected non-default headed runtime @headful
View Logs
tests/e2e/ssh-orcad-explorer-watch-recovery.spec.ts/
remote folder explorer receives host-created files after server restart
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
main's comment cleanup (stablyai#33249) shortened the header of
plugin-chrome-allowlist.test.ts to one line, and this branch extended
the same header for its per-component count test. The header keeps
main's one line, now naming the third check. No code changed.
smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment
cleanup (stablyai#33249) applied that across the repository. This brings the
comments this branch adds in line with it. No code changes.
smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
main's comment cleanup (stablyai#33249) shortened the comment above
pluginLocaleIdSchema to one line, next to the isWellFormedLocaleId
helper this branch adds. The helper and the schema refine are kept as
they were; the comment takes main's line plus one line for why Intl
checks the grammar.
smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment
cleanup (stablyai#33249) applied that across the repository. This brings the
comments this branch adds in line with it. No code changes.
smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
main's comment cleanup (stablyai#33249) reworded a comment inside the inline
commitSyncTitle ladder, which this branch moves into
source-control-dropdown-copy.ts. The branch's call to the moved
function is kept, and the moved comment takes main's wording. No code
changed on main's side of the conflict.
smwbev added a commit to smwbev/orca that referenced this pull request Oct 25, 2026
AGENTS.md asks for one-line comments that say why, and main's comment
cleanup (stablyai#33249) applied that across the repository. This brings the
comments this branch adds in line with it. No code changes.
DoozyX added a commit to DoozyX/orca that referenced this pull request Oct 26, 2026
Merge stablyai/orca main b759a95 into fork main 83fb74d.
66 conflicts, mostly upstream's repo-wide comment audit (stablyai#33249): fork code kept with upstream comments.
Code-level combinations: mailbox pointer delivery (stablyai#33639) with the fork's queued/injected outcome;
held-batch lookup spans every outstanding typed delivery (fork schema v44); launched-agent write guard
keeps the fork settle loop plus upstream's write-if-shell-provable policy; worker-start keeps the fork's
refusal to guess the coordinator (upstream test adapted); monitored-work rows stay out of Claude agent view.
Files over max-lines are split without behavior change (group settings dialog gets its own hook).
jinho-yoo-jack added a commit to jinho-yoo-jack/orca that referenced this pull request Oct 27, 2026
Brings the branch up to upstream 7782fd5. Resolves two conflicts:

- TabGroupSplitNodeTree.tsx: keep the grid view's isWorktreeFocused gate
  and adopt the one-line comment from upstream's comment cleanup (stablyai#33249).
- en.json: keep upstream's new ClaudeAgentViewIndicator keys alongside the
  grid view keys; sync:localization-catalog reports no further changes.

store/index.ts, store/types.ts, store-test-helpers.ts and
wsl-move-storage-dispositions.ts merged cleanly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OrcaWin added a commit that referenced this pull request Oct 27, 2026
* fix(plugins): reject locale ids Intl cannot parse

`pluginLocaleIdSchema` checks the shape of a locale id but not its grammar,
and the shape check is looser than BCP 47 in one direction: `en-US-US`
(duplicate region) and `en-aaa` (a subtag that is neither region nor script)
both match it. A pack declaring one installs, loads, and translates every
string — and then `Intl.DateTimeFormat` throws inside `getIntlLocale()`, which
swallows the error and falls back to English. Nothing is logged, so the pack
author sees a working pack with English dates and no way to tell why.

Delegate the grammar to `Intl.getCanonicalLocales` in a `.refine`, so the tag
is rejected at install where the author can still act on it. The bundled
`pt-BR` pack and every other well-formed tag are unaffected.

* Condense this branch's comments to one line

AGENTS.md asks for one-line comments that say why, and main's comment
cleanup (#33249) applied that across the repository. This brings the
comments this branch adds in line with it. No code changes.

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant