Repository navigation
chore(terminal): drop a third-party product name from a fit comment - #13259
brennanb2025 wants to merge 1 commit into
Conversation
The comment justified coalescing drag-driven resizes by citing another product by name. The reasoning stands on its own; the attribution does not belong in shipped source. Comment only - no behavior change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as already addressed by the merged comment cleanup in #33249 (commit 7d6603a). This PR changes only the comment in |
Summary
A comment in
pane-fit-resize-observer.tsjustified coalescing drag-driven resizes by citing another product by name. The engineering reasoning stands on its own; the attribution does not belong in shipped source.Comment only — no behavior change.
Screenshots
No visual changeTesting
pnpm lintpnpm typecheckpnpm testpnpm buildNo tests — this changes two lines of comment text and no executable code.
oxlintandoxfmt --checkpass on the file.AI Review Report
Swept
src/anddocs/for similar references. The remaining matches are all legitimate and deliberately left alone:supersetused as the ordinary English word ("a superset of its internal guards").src/shared/setup-script-imports.ts, which reads.superset/config.jsonas a user-facing setup-script import source. That is interop with a real config format the user may have on disk, plus its user-visible provider label — removing it would break a feature, not scrub a citation.Cross-platform: comment text only.
Security Audit
No code change. No IPC, input handling, command execution, path handling, auth, secrets, or dependencies touched.
Notes
Split out from the floating-workspace restore work (#13258) rather than folded in, since it is unrelated to that fix.