Skip to content

chore(terminal): drop a third-party product name from a fit comment - #13259

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/scrub-third-party-name-in-fit-comment
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/scrub-third-party-name-in-fit-comment

Conversation

@brennanb2025

Copy link
Copy Markdown
Contributor

Summary

A comment in pane-fit-resize-observer.ts justified coalescing drag-driven resizes by citing another product by name. The engineering reasoning stands on its own; the attribution does not belong in shipped source.

Comment only — no behavior change.

Screenshots

No visual change

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • Added or updated high-quality tests that would catch regressions, or explained why tests were not needed

No tests — this changes two lines of comment text and no executable code. oxlint and oxfmt --check pass on the file.

AI Review Report

Swept src/ and docs/ for similar references. The remaining matches are all legitimate and deliberately left alone:

  • superset used as the ordinary English word ("a superset of its internal guards").
  • src/shared/setup-script-imports.ts, which reads .superset/config.json as a user-facing setup-script import source. That is interop with a real config format the user may have on disk, plus its user-visible provider label — removing it would break a feature, not scrub a citation.

Cross-platform: comment text only.

Security Audit

No code change. No IPC, input handling, command execution, path handling, auth, secrets, or dependencies touched.

Notes

Split out from the floating-workspace restore work (#13258) rather than folded in, since it is unrelated to that fix.

The comment justified coalescing drag-driven resizes by citing another
product by name. The reasoning stands on its own; the attribution does not
belong in shipped source.

Comment only - no behavior change.
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bde3d2c8-31b8-47a7-8c7a-eb250356a26f

📥 Commits

Reviewing files that changed from the base of the PR and between 04f7123 and 4ea46b4.

📒 Files selected for processing (1)
  • src/renderer/src/lib/pane-manager/pane-fit-resize-observer.ts

📝 Walkthrough

Walkthrough

Updated the requestStablePaneFit comment to explain that the browser coalesces divider drag resize changes before xterm fitting. Runtime behavior remains unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of a third-party product name from a fit comment.
Description check ✅ Passed The description covers the summary, visual impact, testing, AI review, security audit, and notes for this comment-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin

OrcaWin commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Closing as already addressed by the merged comment cleanup in #33249 (commit 7d6603a).

This PR changes only the comment in requestStablePaneFit in src/renderer/src/lib/pane-manager/pane-fit-resize-observer.ts to remove the Superset attribution. Current main has already replaced that entire comment with: “Coalesce divider fits off pointermove; require a stable grid to avoid Windows sidebar/scrollbar wobble causing Codex SIGWINCH loops.” The attribution is gone and the engineering rationale remains, so this PR has no remaining change to land.

@OrcaWin OrcaWin closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants