Repository navigation
test(mobile): split MobileNativeChatView.test.ts under the max-lines limit - #29368
Merged
Merged
Conversation
…limit Pure move: the 36 test cases and their assertions are unchanged, now in six feature files. Shared mocks and render helpers live in MobileNativeChatView.harness.test-fixture.ts. The only non-move edits are typing and formatting: the harness adds getComposerEditGeneration to its default props (a required prop the fixture never passed), tests use hostType(node) for tag comparisons, and the typecheck baseline and reliability gate paths drop the removed file.
This was referenced Oct 16, 2026
9 tasks done
1 task done
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's lint has been failing since e9c7736 (#29099) because mobile/src/session/MobileNativeChatView.test.ts is 806 counted lines, over the 800 max-lines limit, and that blocks every PR. This PR splits the file into six feature files (stop control, failure banners, rows and streaming bubble, composer lock and prompt cards, tail-follow, history paging) plus one shared fixture module for the mocks and render helpers. It is a pure move: the 36 test cases and their assertions are unchanged, and no lint rule or max-lines limit was changed or disabled.