Repository navigation
ci: move the final PR report off the busy runner pool - #29337
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the primary change: moving the final PR report to a less busy runner pool. Description check The description is complete and focused. It explains the change, motivation, linked issue, testing, review details, scope, and checklist status. It also documents the React Native fixture allowance an…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
c29c334b-4ffa-4dd9-bd22-4fa1aef05ba5
📒 Files selected for processing: 1
.github/workflows/pr.yml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
| - layout_oracle | ||
| runs-on: ubuntu-slim | ||
| # Report settled results without competing with the GitHub-hosted test queue. | ||
| runs-on: blacksmith-2vcpu-ubuntu-2204 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
✅ Runtime observed
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- actionlint-related files ---'
fd -a -g '*actionlint*' . || true
printf '%s\n' '--- actionlint configuration, invocations, and runner labels ---'
rg -n -C 2 'actionlint|blacksmith-2vcpu-ubuntu-2204' . || trueRepository: stablyai/orca
Length of output: 249
🏁 Script executed:
set -euo pipefail
printf '%s\n' '--- diff for the reviewed change ---'
git diff --no-ext-diff --unified=25 e9c77360f545986a1eb2eac6cdc0d05fe116435e a5caa701c49e725de3c2863fac0ed9bbab1ad8fb -- .github/workflows/pr.yml
printf '%s\n' '--- actionlint references and configuration, including hidden files ---'
rg --hidden -n -C 3 --glob '!.git/**' -e 'actionlint' -e 'blacksmith-2vcpu-ubuntu-2204' . || test "$?" -eq 1
printf '%s\n' '--- relevant repository metadata and workflow files ---'
rg --files --hidden -g '!.git/**' | rg '(^|/)(package\.json|Makefile|Taskfile[^/]*|actionlint[^/]*|\.github/.*|\.config/.*|scripts?/.*)$' | sortRepository: stablyai/orca
Length of output: 41133
🏁 Script executed:
set -u
printf '%s\n' '--- actionlint availability ---'
if command -v actionlint >/dev/null 2>&1; then
actionlint --version
printf '%s\n' '--- actionlint output for changed workflow ---'
actionlint .github/workflows/pr.yml
else
printf '%s\n' 'actionlint is not installed'
fi
printf '%s\n' '--- exact repository references ---'
git grep -n -I -e 'actionlint' -- ':!*.lock' ':!.git' || trueRepository: stablyai/orca
Length of output: 9063
Configure actionlint for the Blacksmith runner label if CI uses it.
actionlint 1.7.12 reports blacksmith-2vcpu-ubuntu-2204 as an unknown label at .github/workflows/pr.yml:1520. If CI or another required check runs actionlint on this workflow, add the label to actionlint.yaml. The repository contains no actionlint invocation, so the impact depends on external validation.
🧰 Tools
🪛 actionlint (1.7.12)
[error] 1520-1520: label "blacksmith-2vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2025-vs2026", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xlarge", "macos-latest-large", "macos-26-intel", "macos-26-xlarge", "macos-26-large", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xlarge", "macos-14-large", "macos-14", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
Source: Linters/SAST tools
OrcaWin
changed the title
bf43131 to
63018fc
Compare
63018fc to
fb15233
Compare
OrcaWin
changed the title
ELI5
PRs can finish their tests and then wait many more minutes just to report success. Move that final report to Orca’s existing Blacksmith Linux runner pool.
What Changed
Run only
pr.yml:verifyonblacksmith-2vcpu-ubuntu-2204. Its explicit pass/fail result, required dependencies and failure handling are unchanged.Also retain the existing test mock allowance for the exact React Native fixture extracted by #29368. That split on main moved the mocks outside the test-file pattern and broke the full preflight audit. No test or application code changes.
Why
Today’s sampled ARM jobs waited a median 22 minutes, and finished PRs also queued their final report. The existing Blacksmith pool had a sampled prior-day queue p95 of 0.3 minutes; a production job today started in 11 seconds.
This preserves an explicit green gate instead of restoring #29136’s skipped-success approach. It uses the existing paid pool for a tiny reporting job; the larger test queue still needs capacity.
Linked Issue
Follow-up to #29228; maintainer CI maintenance.
Visual Proof
N/A — one workflow runner change.
Testing
On head
fcaf3ebdaba8c315489a88644c4f2aea8c46a163, based ona49295f024:pnpm tc, root Oxlint, required-context validation, formatting andgit diff --checkpassed.All required jobs passed for this exact head in PR Checks run 38844246974, from
.github/workflows/pr.yml. All five unit shards, relay integration, compatibility checks, both package jobs and both selected layout checks passed. The explicitverifyjob succeeded onblacksmith-2vcpu-ubuntu-2204: 11 seconds queued and six seconds running. The optional unit-selection evidence report is still queued and is excluded from the required gate.Review
The final job’s shell, environment, dependencies, permissions, timeout, condition and required check name remain unchanged. No checkout or third-party action runs in that job.
Agent skill upstream boundary
Notes
Uses an existing runner pool and its allowance. No application, platform, SSH, mobile or wire behavior changes.
Checklist