Repository navigation
[CI] Reduce test imports, clock waits, and headless cleanup costs - #29312
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
cebc515 to
26461cd
Compare
26461cd to
30b6a1c
Compare
a37adbf to
c1687a6
Compare
a7ea99b to
4fd0456
Compare
4fd0456 to
b8a5ab9
Compare
ELI5
CI spends less time loading unrelated app code, waiting on test clocks, repeating replay formatting, and closing headless hosts. Existing behavior checks stay in place.
What Changed
Why
These changes remove setup and waits that the tests do not need. Reusing existing fixture APIs keeps real actions, subscriptions, IPC, server lifecycle, and behavioral assertions in place. The popup setting addresses hidden compositor scheduling; the original intermittent first-frame failure did not reproduce locally, so its cause remains unproved.
Local comparisons apply to separate cohorts and must not be added into a fleet speed estimate. The mobile four-root cohort retained all 47 cases across four matched AB/BA pairs: median paired command saving 3.558s, with sampled process-group RSS 20.45–26.98% lower in every pair. One pair regressed in summed worker phases, so full-shard savings remain unproved. The final combined checks below are a correctness refresh, not another benchmark.
Linked Issue
N/A — maintainer-requested CI capacity work.
Visual Proof
N/A — test and workflow changes; no product UI or interaction change. Hidden Electron qualification runs on an isolated display or CI.
Testing
b8a5ab93ca7427f106896792925072cbc31ef224: 439 affected tests passed with the same two existing skips (441 cases); all prior 393 constituent case identities/outcomes retained, all 47 mobile cases retained, and one cleanup regression added. All 53 routing cases passed. Direct Node compatibility also passed the 126-case clock cohort.pnpm lintstopped at five existing mobile import-cycle warnings across four untouched files; the later checks in that chained command were not claimed as run.The first combined invocation omitted the Node-worker executable binding and exited nonzero with several roots unexecuted. The corrected repository-wrapper invocation above passed with explicit Node 24.20.0; its complete case catalog was verified. No source change or assertion retry was used to resolve that launcher error.
7cf0c2a5, including its new regression and the strict store mock; original branch/head restored clean.Hosted observations against the earlier qualified batch: the same 26 changed roots totalled 79.354→37.284 worker-seconds; the slowest unit test step was 355→339 seconds and summed five-shard test-step occupancy 1711→1652 seconds. Sources, shard assignments and diagnostic overhead differ, and this is one observation per condition. These are not isolated causal or fleet savings; no candidate import-phase split is available.
Review
Test isolation, case assertions, timeout budgets, retries, native/process checks, SSH host authority, and mixed-version RPC behavior are preserved. No library or native dependency update is included. Independent source reviews and the hosted checks above qualify the exact published commit; all executed required checks passed.
Agent skill upstream boundary
Checklist