Skip to content

CICS: UNLOCK without TOKEN releases the file's READ UPDATE hold (Part of #5079) - #5095

Merged
squid-protocol merged 4 commits into
mainfrom
churn/5079-20261014T0928Z
Oct 14, 2026
Merged

squid-protocol merged 4 commits into
mainfrom
churn/5079-20261014T0928Z

Conversation

@squid-protocol

@squid-protocol squid-protocol commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Part of #5079 (not closing it: the other old-style members remain).

Class: releasing the file's tokenless READ UPDATE hold (same mechanism as tokenless REWRITE / DELETE-held).

  • CicsTask.unlockHeld, stub GGCUNLK without TOKEN, det Cics.file_update, equivalence harness, spec (UNLOCK INVREQ outcome), X52 register entry.
  • Nothing held -> NORMAL, RESP2 0: IBM states "no action is taken and a NORMAL response is returned". WRITE MASSINSERT (the other match IBM names) is not modelled and stays refused.
  • Tests: test_unlock_held_5079.py (one scenario list on stub and CicsTask: held/unheld/other file/token hold/SYNCPOINT/NOTFND), translate tests updated.

Gates: pr_gates.py --fast 6/6 pass; --ratchets 7/7 pass; audit_check.py clear; changed tests pass (det_translate, equivalence_cics; Docker cells skipped).

Sibling gaps (still refused by name): ADDRESS COMMAREA/CWA/TWA/TCTUA/EIB + ADDRESS SET, READ/RECEIVE/RETRIEVE SET (pointer lane #5041/#5042), READQ TD / DELETEQ TD (TD read model), SEND PAGE / PURGE MESSAGE, terminal CONVERSE, POST/WAIT EVENT.

Cross-repo: none; no crucible pin bump (hand-traced crucible case not added: the stub scenario list is the proof).

🤖 Generated with Claude Code

… of #5079)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🐦‍⬛ Muninn Security Scan

✅ No security issues found.

🐦‍⬛ Powered by Muninn · Skald Lab

… of #5079)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol added the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol marked this pull request as ready for review October 14, 2026 09:55
@squid-protocol
squid-protocol enabled auto-merge (squash) October 14, 2026 09:55
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol squid-protocol added the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Oct 14, 2026
@squid-protocol squid-protocol removed the shepherd:retrying Bot: an infra/flake rerun is pending on this head. Guide: docs/ci.md label Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

PR #5095 @ 4c28595: 1 failed check(s)

== det (failure) -- real
https://github.com/squid-protocol/gitgalaxy/actions/runs/38545588720/job/115843157796
repro: tests/tools/box/heavy-run.sh python tests/tools/proof_sweep.py --det-only --skip-db2 --cases --work /tmp/gitgalaxy-scratch/ci-digest/sweep
errors:
Traceback (most recent call last):
ValueError: det cbsa-bnk1dcs: in two shards (shards/det-sweep-shard-13/sweep.json)
##[error]Process completed with exit code 1.
log tail:
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.15/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.15/x64/lib
PLAN_RESULT: success
MODE: full
CASES: all
SHARDS: 20
DB2_CASES: all
DB2_SHARDS: 4
EVENT: pull_request
##[endgroup]
Traceback (most recent call last):
File "/home/runner/work/gitgalaxy/gitgalaxy/tests/tools/proof_sweep.py", line 364, in
sys.exit(main())
^^^^^^
File "/home/runner/work/gitgalaxy/gitgalaxy/tests/tools/proof_sweep.py", line 272, in main
results = merge_sweeps(args.aggregate)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/work/gitgalaxy/gitgalaxy/tests/tools/proof_sweep.py", line 137, in merge_sweeps
raise ValueError(f"{sweep} {case}: in two shards ({f})")
ValueError: det cbsa-bnk1dcs: in two shards (shards/det-sweep-shard-13/sweep.json)
##[error]Process completed with exit code 1.
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/7ba3e0f1-eb8b-44c0-8cb1-c03d7d012b23' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/gitgalaxy/gitgalaxy
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http.https://github.com/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes

@squid-protocol squid-protocol added the shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md label Oct 14, 2026
squid-protocol and others added 2 commits October 14, 2026 08:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…5092 merged) (Part of #5079)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@squid-protocol squid-protocol removed the shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md label Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

CI shepherd: the head of this PR (46ebab0) is not the one a maintainer labelled shepherd:merge on (new commits, or never approved), so the label was removed and nothing merges unreviewed code. Re-add the label when the new head is ready (shepherd:reapprove marks this PR until then).

@squid-protocol squid-protocol added shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md and removed shepherd:needs-fix Bot: a real failure on this head; see the digest comment. Guide: docs/ci.md shepherd:reapprove Bot: new commits dropped shepherd:merge; re-add it to merge this head. Guide: docs/ci.md labels Oct 14, 2026
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol enabled auto-merge (squash) October 14, 2026 13:05
@squid-protocol

Copy link
Copy Markdown
Owner Author

No description provided.

@squid-protocol
squid-protocol merged commit 1ecbe94 into main Oct 14, 2026
75 checks passed
@squid-protocol
squid-protocol deleted the churn/5079-20261014T0928Z branch October 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shepherd:merge Maintainer: merge when green (auto-merge, squash). Guide: docs/ci.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant