Skip to content

Fix #309 Fallback to no-emoji boot message when failing to load for some reason - #311

Merged
seratch merged 4 commits into
slackapi:mainfrom
seratch:issue-309-boot-message
Apr 29, 2021
Merged

seratch merged 4 commits into
slackapi:mainfrom
seratch:issue-309-boot-message

Conversation

@seratch

@seratch seratch commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

This pull request resolves #309 . Doing this way eliminates the possibility of unicode loading errors when booting a Bolt app on any platforms.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.6.0 milestone Apr 28, 2021
@seratch seratch self-assigned this Apr 28, 2021
@codecov

codecov Bot commented Apr 28, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #311 (27142d5) into main (ad622e4) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   91.45%   91.38%   -0.07%     
==========================================
  Files         166      166              
  Lines        5278     5283       +5     
==========================================
+ Hits         4827     4828       +1     
- Misses        451      455       +4     
Impacted Files Coverage Δ
slack_bolt/util/utils.py 84.61% <50.00%> (-9.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad622e4...27142d5. Read the comment docs.

@seratch
seratch merged commit c649e2b into slackapi:main Apr 29, 2021
@seratch
seratch deleted the issue-309-boot-message branch April 29, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback to no-emoji boot message when failing to load for some reason

2 participants