Skip to content

Fix #309 Fallback to no-emoji boot message when failing to load for some reason #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 4 commits into from
Apr 29, 2021
Merged

Fix #309 Fallback to no-emoji boot message when failing to load for some reason #311

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
502064e
Fix #309 Fallback to no-emoji boot message when failing to load for s…
seratch Apr 28, 2021
431cb69
Merge branch 'main' into issue-309-boot-message
seratch Apr 28, 2021
5ce393d
Merge branch 'main' into issue-309-boot-message
seratch Apr 28, 2021
27142d5
Merge branch 'main' into issue-309-boot-message
seratch Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions slack_bolt/util/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,19 @@ def get_boot_message(development_server: bool = False) -> str:
else:
return "Bolt app is running!"

if development_server:
return "⚡️ Bolt app is running! (development server)"
else:
return "⚡️ Bolt app is running!"
try:
if development_server:
return "⚡️ Bolt app is running! (development server)"
else:
return "⚡️ Bolt app is running!"
except ValueError:
# ValueError is a runtime exception for a given value
# It's a super class of UnicodeEncodeError, which may be raised in the scenario
# see also: https://github.com/slackapi/bolt-python/issues/170
if development_server:
return "Bolt app is running! (development server)"
else:
return "Bolt app is running!"


def get_name_for_callable(func: Callable) -> str:
Expand Down