docs(time): clarify exact seconds for week and day by sorairolake · Pull Request #162195 · rust-lang/rust

sorairolake · 2026-09-02T14:21:32Z

Documented that Duration::from_weeks defines one week as 604,800 seconds (7 days), and Duration::from_days defines one day as 86,400 seconds (24 hours).

Doctests for these methods also appear to be based on these definitions.

The purpose of this is to clarify that Duration is a fixed length value that ignores factors such as DST or a leap second.

This is inspired by rust-lang/libs-team#869 (comment).

See also #120301

@rustbot label +A-docs

rustbot · 2026-09-02T14:21:38Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from JohnTitor, Mark-Simulacrum, clarfonthey

sorairolake · 2026-09-02T16:30:01Z

r? @jhpratt

rustbot · 2026-09-02T16:30:07Z

jhpratt is not on the review rotation at the moment.
They may take a while to respond.

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

sorairolake · 2026-09-03T01:37:58Z

r?

rustbot · 2026-09-03T01:38:00Z

Error: Parsing assign command in comment failed: specify user to assign to (if you want to reroll without a specific reviewer in mind, use @rustbot reroll)

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

sorairolake · 2026-09-03T01:38:34Z

@rustbot reroll

jhpratt · 2026-09-03T01:41:30Z

Ignore that; I put myself in the discussion and can definitely review something small like this :)

r? jhpratt

@bors r+ rollup

rust-bors · 2026-09-03T01:41:34Z

📌 Commit 75ff1f5 has been approved by jhpratt

It is now in the queue for this repository.

@rustbot

…ds, r=jhpratt docs(time): clarify exact seconds for week and day Documented that `Duration::from_weeks` defines one week as 604,800 seconds (7 days), and `Duration::from_days` defines one day as 86,400 seconds (24 hours). Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as DST or a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

Rollup of 29 pull requests Successful merges: - #161694 (add `Complex` ABI run-make test) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162164 (Revert "Implement Debug for C-like enums with a concatenated string") - #160564 (volatile: allow accesses to non-AM memory to trap) - #161579 (suggest calling a fn item used as the iterator of a `for` loop) - #162044 (coverage: Resolve spans to file-coordinates in a separate step) - #162120 (Introduce `PerOwnerLoweringState`) - #162132 (std: improve safety documentation in UNIX stack overflow code) - #162151 (Test itanium mangling of `f16` and `f128`) - #162162 (Don't special-case `!` in stability checks anymore) - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 ) - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`) - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants) - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia) - #161847 (Preserve visibility in nested macro import suggestions) - #161951 (Windows: add fallback if `canonicalize` fails) - #161972 (Improve tests for `#[track_caller]` in async) - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery) - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`) - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`) - #162152 (Revert "retrieve supported GCC targets from the sysroot") - #162153 (Prefer `LLVMGetVersion` for runtime info) - #162168 (fix ICE in project_goals/inherent) - #162171 (Explain LoongArch f16 NaN-boxing in inline asm) - #162173 (fix supposedly unreachable `bug!` being reachable) - #162180 (remove outdated next-solver FIXMEs) - #162191 (core: mark float `ClampBounds` methods as `#[inline]`) - #162195 (docs(time): clarify exact seconds for week and day) - #162199 (docs(time): clarify exact seconds for hour and minute)

@rustbot

…ds, r=jhpratt docs(time): clarify exact seconds for week and day Documented that `Duration::from_weeks` defines one week as 604,800 seconds (7 days), and `Duration::from_days` defines one day as 86,400 seconds (24 hours). Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as DST or a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…ds, r=jhpratt docs(time): clarify exact seconds for week and day Documented that `Duration::from_weeks` defines one week as 604,800 seconds (7 days), and `Duration::from_days` defines one day as 86,400 seconds (24 hours). Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as DST or a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…ds, r=jhpratt docs(time): clarify exact seconds for week and day Documented that `Duration::from_weeks` defines one week as 604,800 seconds (7 days), and `Duration::from_days` defines one day as 86,400 seconds (24 hours). Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as DST or a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. See also rust-lang#120301 @rustbot label +A-docs

@rustbot

…conds, r=jhpratt docs(time): clarify exact seconds for hour and minute Documented that `Duration::from_hours` defines one hour as 3,600 seconds (60 minutes), and `Duration::from_mins` defines one minute as 60 seconds. Doctests for these methods also appear to be based on these definitions. The purpose of this is to clarify that `Duration` is a fixed length value that ignores factors such as a leap second. This is inspired by <rust-lang/libs-team#869 (comment)>. It seems that no library in Rust handle leap seconds, so there isn't much point in documenting this. However, I don't think it would hurt to include it for the sake of consistency with rust-lang#162195. See also rust-lang#120301 @rustbot label +A-docs

docs(time): clarify exact seconds for week and day

75ff1f5

rustbot assigned Mark-Simulacrum Sep 2, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 2, 2026

rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Sep 2, 2026

sorairolake mentioned this pull request Sep 2, 2026

docs(time): clarify exact seconds for hour and minute #162199

Open

rustbot assigned jhpratt and unassigned Mark-Simulacrum Sep 2, 2026

rustbot assigned clarfonthey and unassigned jhpratt Sep 3, 2026

rustbot assigned jhpratt Sep 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2026

rustbot unassigned clarfonthey Sep 3, 2026

Zalathar mentioned this pull request Sep 3, 2026

Rollup of 29 pull requests #162221

Closed

JonathanBrouwer mentioned this pull request Sep 3, 2026

Rollup of 12 pull requests #162249

Closed

JonathanBrouwer mentioned this pull request Sep 3, 2026

Rollup of 13 pull requests #162251

Closed

JonathanBrouwer mentioned this pull request Sep 3, 2026

Rollup of 12 pull requests #162254

Open

Navigation Menu

Uh oh!

Uh oh!

docs(time): clarify exact seconds for week and day - #162195

docs(time): clarify exact seconds for week and day#162195
sorairolake wants to merge 1 commit into
rust-lang:mainfrom
sorairolake:clarify-week-day-seconds

sorairolake commented Sep 2, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Sep 2, 2026

Uh oh!

sorairolake commented Sep 2, 2026

Uh oh!

rustbot commented Sep 2, 2026

Uh oh!

sorairolake commented Sep 3, 2026

Uh oh!

rustbot commented Sep 3, 2026

Uh oh!

sorairolake commented Sep 3, 2026

Uh oh!

jhpratt commented Sep 3, 2026

Uh oh!

rust-bors Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

sorairolake commented Sep 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 2, 2026

Uh oh!

sorairolake commented Sep 2, 2026

Uh oh!

rustbot commented Sep 2, 2026

Uh oh!

sorairolake commented Sep 3, 2026

Uh oh!

rustbot commented Sep 3, 2026

Uh oh!

sorairolake commented Sep 3, 2026

Uh oh!

jhpratt commented Sep 3, 2026

Uh oh!

rust-bors Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sorairolake commented Sep 2, 2026 •

edited by rustbot

Loading