remove outdated next-solver handling - #162180
Open
lcnr wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
lcnr
commented
Sep 2, 2026
| self.param_env, | ||
| ty::ClauseKind::WellFormed(xform_ret_ty.into()), | ||
| )); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
we now also eagerly normalize with the new solver
lcnr
commented
Sep 2, 2026
| @@ -1577,10 +1571,7 @@ impl<'a, 'tcx> TypeErrCtxt<'a, 'tcx> { | |||
| let (expected_found, exp_found, is_simple_error, values, param_env) = match values { | |||
| None => (None, Mismatch::Fixed("type"), false, None, None), | |||
Contributor
Author
There was a problem hiding this comment.
we now also eagerly normalize with the new solver
lcnr
commented
Sep 2, 2026
| let unnormalized_term = data.projection_term.to_term(self.tcx, ty::IsRigid::No); | ||
| // FIXME(-Znext-solver): For diagnostic purposes, it would be nice | ||
| // to deeply normalize this type. | ||
| let normalized_term = ocx.normalize( |
Contributor
Author
There was a problem hiding this comment.
same :>
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 3, 2026
remove outdated next-solver FIXMEs see inline comments
lcnr
changed the title
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
Rollup of 29 pull requests Successful merges: - #161694 (add `Complex` ABI run-make test) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162164 (Revert "Implement Debug for C-like enums with a concatenated string") - #160564 (volatile: allow accesses to non-AM memory to trap) - #161579 (suggest calling a fn item used as the iterator of a `for` loop) - #162044 (coverage: Resolve spans to file-coordinates in a separate step) - #162120 (Introduce `PerOwnerLoweringState`) - #162132 (std: improve safety documentation in UNIX stack overflow code) - #162151 (Test itanium mangling of `f16` and `f128`) - #162162 (Don't special-case `!` in stability checks anymore) - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 ) - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`) - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants) - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia) - #161847 (Preserve visibility in nested macro import suggestions) - #161951 (Windows: add fallback if `canonicalize` fails) - #161972 (Improve tests for `#[track_caller]` in async) - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery) - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`) - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`) - #162152 (Revert "retrieve supported GCC targets from the sysroot") - #162153 (Prefer `LLVMGetVersion` for runtime info) - #162168 (fix ICE in project_goals/inherent) - #162171 (Explain LoongArch f16 NaN-boxing in inline asm) - #162173 (fix supposedly unreachable `bug!` being reachable) - #162180 (remove outdated next-solver FIXMEs) - #162191 (core: mark float `ClampBounds` methods as `#[inline]`) - #162195 (docs(time): clarify exact seconds for week and day) - #162199 (docs(time): clarify exact seconds for hour and minute)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 3, 2026
remove outdated next-solver handling see inline comments
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 3, 2026
remove outdated next-solver handling see inline comments
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 3, 2026
remove outdated next-solver handling see inline comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see inline comments