Move more `rustdoc-html` tests using `--test` into the right folder by GuillaumeGomez · Pull Request #162014 · rust-lang/rust

GuillaumeGomez · 2026-08-30T14:27:30Z

Follow-up of #161944.

I double-checked if more rustdoc-html tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

Oh also second commit is me realizing that some ui tests were using compile-args (which doesn't exist anymore) and without @. Anyway, fixed that too.

r? @fmease

fmease

review of 1st commit

View changes since this review

fmease

Nice! Thanks a lot!

I wonder if we should at some point modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

r=me once nits addressed

View changes since this review

GuillaumeGomez · 2026-08-30T14:51:38Z

I wonder if we should modify compiletest or extend tidy to error on rustdoc-html/ tests that don't contain any HtmlDocCk directives... hmm, maybe that's a horrible idea

On it. ;)

I'll send a patch to prevent that in the future (in compiletest I guess, doesn't seem like a tidy thing).

fmease · 2026-08-30T16:49:01Z

@@ -1,5 +1,4 @@
 //@ check-pass
-// compile-args: --cap-lints=warn -Fwarnings


Wait, this should be converted to //@ compile-flags like you did before. This test specifically intended to test the interaction between --cap-lints=warn and -Fwarnings as the paragraph states below.

Or did that lead to a failure? If so we might want to open a GH issue & investigate further.

View changes since the review

https://github.com/rust-lang/rust/pull/162014/changes#r3889950590

This has not been addressed yet.

I was confused because the test was expecting WARN messages. But based on the test description, it shouldn't. So I removed the WARN annotations and uncommented the line.

fmease · 2026-08-30T16:51:23Z

Accidental removal while trying to apply #162014 (comment) (there's still the corresp. *.stderr file)?.

View changes since the review

#162014 (comment)

This has not been addressed yet.

Arf indeed, fixed.

GuillaumeGomez · 2026-08-31T14:07:12Z

@bors r=fmease rollup

rust-bors · 2026-08-31T14:07:16Z

📌 Commit 614d9ea has been approved by fmease

It is now in the queue for this repository.

rustbot · 2026-08-31T16:30:34Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rust-bors · 2026-08-31T16:30:35Z

⚠️ A new commit fa9cd5bd4c583c3b5311698485482ad514026c30 was pushed.

This pull request was unapproved.

fmease · 2026-09-02T12:28:08Z

@bors rollup=iffy

@fmease

…ease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of rust-lang#161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

@fmease

…ease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of rust-lang#161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

JonathanBrouwer · 2026-09-02T19:31:28Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162206 (comment)

rust-bors · 2026-09-02T19:31:37Z

This pull request was unapproved.

This PR was contained in a rollup (#162206), which was unapproved.

View changes since this unapproval

fmease · 2026-09-02T19:47:56Z

Probably needs a lot more aggressive backtrace normalization (do we have UI tests we can take as inspiration?)

GuillaumeGomez · 2026-09-02T19:50:30Z

I can finally show my regex skills =D (please make this nightmare stop T_T)

GuillaumeGomez · 2026-09-02T19:54:22Z

Oh, even simpler: only-linux. :3

GuillaumeGomez · 2026-09-02T19:55:58Z

@bors try jobs=x86_64-msvc-1

Move more `rustdoc-html` tests using `--test` into the right folder try-job: x86_64-msvc-1

rust-bors · 2026-09-02T22:37:02Z

☀️ Try build successful (CI)
Build commit: 29c96bd (29c96bda22632f5de3aa2adfd3ae125a3fb48988)
Base parent: 824336a (824336ad4127ce295849937a24c08a4aeff6ada7)

GuillaumeGomez · 2026-09-02T23:53:45Z

@bors r=fmease

rust-bors · 2026-09-02T23:53:48Z

📌 Commit c7a87d0 has been approved by fmease

It is now in the queue for this repository.

@fmease

…ease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of rust-lang#161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

Rollup of 29 pull requests Successful merges: - #161694 (add `Complex` ABI run-make test) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162164 (Revert "Implement Debug for C-like enums with a concatenated string") - #160564 (volatile: allow accesses to non-AM memory to trap) - #161579 (suggest calling a fn item used as the iterator of a `for` loop) - #162044 (coverage: Resolve spans to file-coordinates in a separate step) - #162120 (Introduce `PerOwnerLoweringState`) - #162132 (std: improve safety documentation in UNIX stack overflow code) - #162151 (Test itanium mangling of `f16` and `f128`) - #162162 (Don't special-case `!` in stability checks anymore) - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 ) - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`) - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants) - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia) - #161847 (Preserve visibility in nested macro import suggestions) - #161951 (Windows: add fallback if `canonicalize` fails) - #161972 (Improve tests for `#[track_caller]` in async) - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery) - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`) - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`) - #162152 (Revert "retrieve supported GCC targets from the sysroot") - #162153 (Prefer `LLVMGetVersion` for runtime info) - #162168 (fix ICE in project_goals/inherent) - #162171 (Explain LoongArch f16 NaN-boxing in inline asm) - #162173 (fix supposedly unreachable `bug!` being reachable) - #162180 (remove outdated next-solver FIXMEs) - #162191 (core: mark float `ClampBounds` methods as `#[inline]`) - #162195 (docs(time): clarify exact seconds for week and day) - #162199 (docs(time): clarify exact seconds for hour and minute)

…uwer Rollup of 25 pull requests Successful merges: - #161694 (add `Complex` ABI run-make test) - #162014 (Move more `rustdoc-html` tests using `--test` into the right folder) - #162164 (Revert "Implement Debug for C-like enums with a concatenated string") - #160564 (volatile: allow accesses to non-AM memory to trap) - #161579 (suggest calling a fn item used as the iterator of a `for` loop) - #162044 (coverage: Resolve spans to file-coordinates in a separate step) - #162120 (Introduce `PerOwnerLoweringState`) - #162132 (std: improve safety documentation in UNIX stack overflow code) - #162151 (Test itanium mangling of `f16` and `f128`) - #162162 (Don't special-case `!` in stability checks anymore) - #162181 (Remove wrong UnusedBraces lint for iterator loop in edition 2024 ) - #162187 (Rename `thir::ExprKind::Use` to `ValueExpr`) - #158401 (mgca: Don't ICE when evaluating ValTrees that contain error constants) - #159873 (fuchsia: Add safestack as a supported sanitizer for x86_64 fuchsia) - #161135 (Add `f16` and `f128` inline ASM support for PowerPC) - #161847 (Preserve visibility in nested macro import suggestions) - #161972 (Improve tests for `#[track_caller]` in async) - #162008 (Render the `box` pattern removal diagnostic more actionable & remove `box` expression recovery) - #162065 (std: don't reference `libc::O_NOFOLLOW` on VxWorks in `set_perm_nofollow`) - #162076 (docs(num): clarify conditions under which error occurs in `impl TryFrom<int> for int`) - #162111 (Update mailmap for Will Crichton and Petr Hosek) - #162152 (Revert "retrieve supported GCC targets from the sysroot") - #162153 (Prefer `LLVMGetVersion` for runtime info) - #162168 (fix ICE in project_goals/inherent) - #162171 (Explain LoongArch f16 NaN-boxing in inline asm)

@fmease

Rollup merge of #162014 - GuillaumeGomez:more-ui-tests, r=fmease Move more `rustdoc-html` tests using `--test` into the right folder Follow-up of #161944. I double-checked if more `rustdoc-html` tests were in the wrong folder and... yeah. So fixing that too. I'll send a patch to prevent that in the future (in `compiletest` I guess, doesn't seem like a `tidy` thing). Oh also second commit is me realizing that some ui tests were using `compile-args` (which doesn't exist anymore) and without `@`. Anyway, fixed that too. r? @fmease

rustbot assigned fmease Aug 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 30, 2026

fmease reviewed Aug 30, 2026

View reviewed changes

fmease approved these changes Aug 30, 2026

View reviewed changes

Comment thread tests/rustdoc-ui/lints/renamed-lint-still-applies.rs Outdated

Comment thread tests/ui/lint/forbid-error-capped.rs Outdated

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2026

GuillaumeGomez force-pushed the more-ui-tests branch from bd5786a to 8374270 Compare August 30, 2026 16:08

fmease reviewed Aug 30, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the more-ui-tests branch from 8374270 to fba1d54 Compare August 30, 2026 19:22

GuillaumeGomez mentioned this pull request Aug 30, 2026

Prevent --test to be used in rustdoc-html testsuite #162030

Open

This comment has been minimized.

Sign in to view

Move more rustdoc-html tests using --test into the right folder

41258df

GuillaumeGomez force-pushed the more-ui-tests branch from fba1d54 to 815bbce Compare August 31, 2026 09:47

This comment has been minimized.

Sign in to view

Fix invalid compile-args ui tests argument

614d9ea

GuillaumeGomez force-pushed the more-ui-tests branch from 815bbce to 614d9ea Compare August 31, 2026 12:27

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2026

GuillaumeGomez force-pushed the more-ui-tests branch from 614d9ea to fa9cd5b Compare August 31, 2026 16:30

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 31, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2026

rust-bors Bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 2, 2026

JonathanBrouwer mentioned this pull request Sep 2, 2026

Rollup of 20 pull requests #162198

Closed

JonathanBrouwer mentioned this pull request Sep 2, 2026

Rollup of 23 pull requests #162206

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2026

Limit new rustdoc-ui tests to linux to prevent backtrace paths mismatch

c7a87d0

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 2, 2026

Auto merge of #162014 - GuillaumeGomez:more-ui-tests, r=<try>

29c96bd

Move more `rustdoc-html` tests using `--test` into the right folder try-job: x86_64-msvc-1

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 2, 2026

Zalathar mentioned this pull request Sep 3, 2026

Rollup of 29 pull requests #162221

Closed

JonathanBrouwer mentioned this pull request Sep 3, 2026

Rollup of 25 pull requests #162229

Merged

rust-bors Bot merged commit 079b5bd into rust-lang:main Sep 3, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Sep 3, 2026

		@@ -1,5 +1,4 @@
		//@ check-pass
		// compile-args: --cap-lints=warn -Fwarnings

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Aug 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fmease left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 30, 2026

Uh oh!

fmease Aug 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

rustbot commented Aug 31, 2026

Uh oh!

rust-bors Bot commented Aug 31, 2026

Uh oh!

fmease commented Sep 2, 2026

Uh oh!

JonathanBrouwer commented Sep 2, 2026

Uh oh!

rust-bors Bot commented Sep 2, 2026

Uh oh!

fmease commented Sep 2, 2026

Uh oh!

GuillaumeGomez commented Sep 2, 2026

Uh oh!

GuillaumeGomez commented Sep 2, 2026

Uh oh!

GuillaumeGomez commented Sep 2, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 2, 2026

Uh oh!

GuillaumeGomez commented Sep 2, 2026

Uh oh!

rust-bors Bot commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

GuillaumeGomez commented Aug 30, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading

fmease left a comment •

edited

Loading

fmease Aug 30, 2026 •

edited by rustbot

Loading

GuillaumeGomez Sep 2, 2026 •

edited

Loading

fmease Aug 30, 2026 •

edited

Loading