Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

MAINT: Bump rapids to 25.08 and some other versions - #145

Merged
seberg merged 11 commits into
rapidsai:mainfrom
seberg:bump-rapids
Oct 8, 2025
Merged

seberg merged 11 commits into
rapidsai:mainfrom
seberg:bump-rapids

Conversation

@seberg

@seberg seberg commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

This is just a start/try. CI will pick up a legate with an older CCCL so this may or may not go through.
Locally, I still have problems around __half (as typical, I guess), but without cupynumeric, so I should have one with CCCL/rapids-cmake already bumped...

This is just a start/try.  CI will pick up a legate with an older CCCL
so this may or may not go through.
Locally, I still have problems around `__half` (as typical, I guess), but
without cupynumeric, so I should have one with CCCL/rapids-cmake already
bumped...

Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
Comment thread cpp/CMakeLists.txt Outdated
# unnecessary in the future.
target_compile_definitions("LegateDataframe" PUBLIC _LIBCUDACXX_HAS_NVFP16=1)
endif()
target_compile_definitions("LegateDataframe" PUBLIC LIBCUDACXX_ENABLE_HOST_NVFP16=1)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try to remove these before merging, but as a quick check couldn't hurt...

Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@copy-pr-bot

This comment was marked as outdated.

Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@seberg
seberg requested a review from RAMitchell October 8, 2025 09:44
@seberg
seberg marked this pull request as ready for review October 8, 2025 09:44
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@seberg

seberg commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Ack, this had worked locally with maybe a slightly older legate... Well, let's see if I can mess with some other definition, heh...

…n't exist

Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
seberg added 2 commits October 8, 2025 04:28
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@seberg

seberg commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Ah, runners and cuda-version were all unrelated, but seems just as well (presuming it works). Somehow round_decimal is problematic, so just sticking with the deprecated round for now.

The actual problem for CPU is that try_import_cudf seems to not trigger correctly. I'll try to remove the importorskip and hopefully that works.
(I.e. it continues to load the file and parametrizations which can't succeed without cudf.)

@seberg

seberg commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Ah, I guess it's plausible that the import succeeds but actually doing anything doesn't... let me add a mini operation instead...

seberg added 2 commits October 8, 2025 06:56
…ated round for now

Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@seberg seberg added the breaking Introduces a breaking change label Oct 8, 2025
Signed-off-by: Sebastian Berg <sebastianb@nvidia.com>
@seberg seberg changed the title MAINT: Bump rapids to 25.08 MAINT: Bump rapids to 25.08 and some other versions Oct 8, 2025
@seberg

seberg commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

OK, some of the updates here aren't strictly necessary, but I think they don't hurt either and things are passing.

I have some bad PTX build locally (not sure why), but I don't think that should be a problem (although it means that the new legate isn't tested with multi-gpu setup yet).

@seberg
seberg merged commit a7e3d4d into rapidsai:main Oct 8, 2025
11 checks passed
@seberg
seberg deleted the bump-rapids branch October 8, 2025 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking Introduces a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants