Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Update legate-nightly channel - #150

Merged
reazulhoque merged 3 commits into
rapidsai:mainfrom
reazulhoque:reazul-update-legate-source-channel
Oct 29, 2025
Merged

reazulhoque merged 3 commits into
rapidsai:mainfrom
reazulhoque:reazul-update-legate-source-channel

Conversation

@reazulhoque

Copy link
Copy Markdown
Contributor

Updating legate nightly conda channel as it has been recently moved.

@reazulhoque
reazulhoque requested a review from seberg October 24, 2025 15:12
@reazulhoque reazulhoque self-assigned this Oct 24, 2025
@seberg

seberg commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Thanks a lot! This is good, but we absolutely need to also change all the occurances in the CI scripts. The README ideally will have both channels for now I guess.

@reazulhoque

Copy link
Copy Markdown
Contributor Author

I thought the conda channels in the CI scripts decides where we're putting the legate-dataframe package. I am not intending to change that. I am intending to change the source of Legate we use to build legate-dataframe. Please correct me if I am wrong.

@seberg

seberg commented Oct 24, 2025 •

Copy link
Copy Markdown
Contributor

Ah no, those are probably the more important ones in the end. The upload channels are also somewhere in the ci scripts/workflow, but I guess it the upload scripts use a different naming convention for the label, so doesn't even show up as legate/label/...

EDIT: The ones you find, are all setup for installing packages. Since they include (except the build one) the special channel for the CI build packages, we don't need to keep legate/label/experimental for our own packages there also.

@seberg

seberg commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Can we already revert the terrible hack from #145? The build failure looks like the legate version with the fix might be uploaded (with available cupynumeric, which I hand't expected).

@reazulhoque

Copy link
Copy Markdown
Contributor Author

Do you mean the hack in cpp/CMakeLists.txt? and the corresponding header file? I can fix that.

Signed-off-by: Reazul Hoque <reazulh@nvidia.com>
@reazulhoque
reazulhoque force-pushed the reazul-update-legate-source-channel branch from 897be10 to 5650dd4 Compare October 24, 2025 19:25
@reazulhoque

reazulhoque commented Oct 24, 2025 •

Copy link
Copy Markdown
Contributor Author

I removed the legate hack, CI is failing at a different spot. @Jacobfaib can you please provide some guidance?

cc: @seberg

@seberg

seberg commented Oct 25, 2025

Copy link
Copy Markdown
Contributor

That error was why the hack existed. It seems we are in a spot in time where my hack started not working anymore (because the work-around in legate to make it easier is gone?!), but cupynumeric isn't using an updated legate yet so we don't have the fix.
(Unless the legate fix wasn't quite enough.)

@Jacobfaib

Copy link
Copy Markdown

Looks like CI is trying to pull 25.10 instead of 25.11

cupynumeric:                      25.10.00.rc7-cuda12_py311_cpu_g4b2e32a6_0 legate/label/rc

so it's not picking up the latest cupynumeric builds. I think this should be 25.11, no?

@seberg

seberg commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

The CI targets a specific 25.10.* version always, so yes if we are on 11 now then all 25.10 needs to be changed to 25.11. I had not realized the nightlies are on 25.11 now.

(I guess ideally we change VERSION in a prior commit, just to have a neat commit to tag, but otherwise, I guess can just tag the current main and put this in with the change)

@seberg

seberg commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Let me just make a "start 25.11" PR/commit...

@reazulhoque

Copy link
Copy Markdown
Contributor Author

@seberg I will need to update the version of legate and cupynumeric. Planning to do it in this PR, does that sound correct?

@seberg

seberg commented Oct 29, 2025 •

Copy link
Copy Markdown
Contributor

Yes, just search for all 25.10 and update it (after a brief sanity check since e.g. comments should remain correct).

Signed-off-by: Reazul Hoque <reazulh@nvidia.com>
@reazulhoque
reazulhoque force-pushed the reazul-update-legate-source-channel branch from ba7d30c to 1b713a5 Compare October 29, 2025 16:26
Signed-off-by: Reazul Hoque <reazulh@nvidia.com>
@reazulhoque
reazulhoque merged commit a84dd29 into rapidsai:main Oct 29, 2025
11 checks passed
@reazulhoque
reazulhoque deleted the reazul-update-legate-source-channel branch October 29, 2025 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants