Skip to content
This repository was archived by the owner on Jul 28, 2026. It is now read-only.
This repository was archived by the owner on Jul 28, 2026. It is now read-only.

Remove very brittle __half complex hack/workaround! #146

Description

@seberg

After #145 the main CMakeLists.txt injects a header include for cpp/include/legate_dataframe/legion_hack which includes a legion_defines.h file with something like:

#include "legate/deps/legion_defines.h"

#ifdef LEGION_USE_CUDA
#undef LEGION_REDOP_HALF
#endif

This is nauseating of course. And also definitely very brittle. Any future errors around __half could be due to it!

This must be remove as soon as https://github.com/nv-legate/legate.internal/pull/1418 exists (or similar).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions