Repository navigation
add wheel output - #369
Merged
Merged
add wheel output#369
Conversation
msarahan
added
improvement
Contributor
|
Yeah for consistency with the rest of RAPIDS using separate C++ and Python wheels is the way to go. We'll be able to leverage that by using the libkvikio wheel during the libcudf wheel build since libcudf needs libkvikio headers. You can see that in your cudf PR those are currently being bundled into the libcudf wheel which is not ideal. Using the libkvikio wheel from this PR instead will fix that. |
11 tasks done
Contributor
Author
|
Error in wheel build: |
msarahan
added a commit
to msarahan/devcontainers
that referenced
this pull request
Apr 30, 2024
rapidsai/kvikio#369 moves the python wheel code one level deeper so that we add support for a dedicated libkvikio wheel. This adjustment needs to be accounted for here. Confused PR run without this change: https://github.com/rapidsai/kvikio/actions/runs/8900188332/job/24441209009#step:7:1446
Contributor
|
Feel free to add this to the devcontainer build job to test the path adjustment in the devcontainers before merging: build_command: |
sudo yq -i '.repos[2].python[0].sub_dir = "python/kvikio"' /opt/rapids-build-utils/manifest.yaml;
rapids-generate-scripts; |
vyasr
requested changes
May 3, 2024
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
msarahan
commented
May 3, 2024
msarahan
marked this pull request as ready for review
June 18, 2024 17:55
bdice
approved these changes
Jun 18, 2024
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
No reservations from me. If it’s working as expected, the diff looks good to me.
jameslamb
reviewed
Jun 18, 2024
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
Ok I'm still reviewing, but publishing this now so you can start making adjustments to some of the rapids-build-backend stuff.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
This was referenced Jun 18, 2024
jameslamb
self-requested a review
June 18, 2024 20:00
jameslamb
approved these changes
Jun 18, 2024
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for all your work!
(and to @hcho3 for helping move it forward too)
Contributor
Author
|
Indeed! Thanks @hcho3 for moving this forward! |
vyasr
approved these changes
Jun 18, 2024
Contributor
|
/merge |
rapids-bot Bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Jun 24, 2024
Contributes to rapidsai/build-planning#31 Removes `.gitattributes` file. That was added in #88 for use with `versioneer`. Per the `git` docs ([link](https://git-scm.com/docs/gitattributes#_export_subst)), setting the attribute `export-subst` on a file via a `.gitattributes` tell `git` to replace placeholders in the file with some `git` information. This is no longer done in `_version.py` files in this project, and this project no longer uses `versioneer`. `rapids-build-backend` handles storing git commit information in the published packages. ## Notes for Reviewers Created based on this conversation: rapidsai/kvikio#369 (comment) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: #1350
vyasr
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Jun 24, 2024
* Account for kvikio python folder nesting rapidsai/kvikio#369 moves the python wheel code one level deeper so that we add support for a dedicated libkvikio wheel. This adjustment needs to be accounted for here. Confused PR run without this change: https://github.com/rapidsai/kvikio/actions/runs/8900188332/job/24441209009#step:7:1446 * Update features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml * add libkvikio python build; bump feature version * add CMake args back * reorder libkvikio to build before kvikio, bump feature version --------- Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com> Co-authored-by: Vyas Ramasubramani <vyasr@nvidia.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Contributes to rapidsai/build-planning#69. Proposes a stricter pattern for passing a `libkvikio` wheel from the `wheel-build-cpp` job that produced it into the `wheel-build-python` job wanting to use it (as a build dependency of `kvikio`). This change improves the likelihood that issues with the `libkivkio` wheels will be caught in CI. ## Notes for Reviewers See rapidsai/rmm#1586 and rapidsai/build-planning#69 (comment) for details on how I tested this approach. I didn't propose this on #369 because I hadn't quite finished testing the approach yet. But I do think we should do this for all of the C++ wheels (rapidsai/build-planning#33). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) URL: #397
vyasr
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Sep 23, 2024
There have been a number of changes to RAPIDS builds over the course of this release and not all changes were fully propagated to the devcontainers repo. This repo addresses the following: - As of rapidsai/kvikio#369, kvikio produces wheels, and rapidsai/kvikio#439 contains critical fixes that allow the kvikio Python wheel to use the C++ libkvikio wheel. In RAPIDS Python builds we have consistently removed support for the Python build triggering the C++ build as we have created C++ wheels since in both conda and pip environments we now expect the library to be found and we do not need to automatically support the more esoteric use case of someone turning off build isolation but not having the C++ library available (devs can handle this case themselves if they wish). As a result, once rapidsai/kvikio#466 is merged, the `FIND_KVIKIO_CPP` variable will be completely superfluous and we can remove that here. - As of NVIDIA/cudf#16640 libcudf no longer links to libarrow and `USE_LIBARROW_FROM_PYARROW` is no longer used. - The libcudf and libcuspatial Python package builds in the devcontainer should (like all other Python packages) omit the CUDA version suffix. For that, they need to use the `rapids_build_backend_args`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #250
I'm not sure if it makes sense to split the wheel into one dedicated wheel for the shared library, and another for the python wrapper. That's what @vyasr has been doing on other libraries, like rapidsai/rmm#1529. If it makes sense here, I'll add that.