Repository navigation
Various fixes to args - #397
Merged
Merged
Conversation
Contributor
Author
|
We can take this out of draft once rapidsai/kvikio#466 merges. |
trxcllnt
approved these changes
Sep 23, 2024
vyasr
marked this pull request as ready for review
September 23, 2024 19:49
vyasr
added a commit
that referenced
this pull request
Sep 23, 2024
I always forget this... For #397 in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a number of changes to RAPIDS builds over the course of this release and not all changes were fully propagated to the devcontainers repo. This repo addresses the following:
FIND_KVIKIO_CPPvariable will be completely superfluous and we can remove that here.USE_LIBARROW_FROM_PYARROWis no longer used.rapids_build_backend_args.