Skip to content

Various fixes to args - #397

Merged
vyasr merged 1 commit into
rapidsai:branch-24.10from
vyasr:fix/manifest_args
Sep 23, 2024
Merged

vyasr merged 1 commit into
rapidsai:branch-24.10from
vyasr:fix/manifest_args

Conversation

@vyasr

@vyasr vyasr commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

There have been a number of changes to RAPIDS builds over the course of this release and not all changes were fully propagated to the devcontainers repo. This repo addresses the following:

  • As of add wheel output kvikio#369, kvikio produces wheels, and Fix several issues with wheel builds kvikio#439 contains critical fixes that allow the kvikio Python wheel to use the C++ libkvikio wheel. In RAPIDS Python builds we have consistently removed support for the Python build triggering the C++ build as we have created C++ wheels since in both conda and pip environments we now expect the library to be found and we do not need to automatically support the more esoteric use case of someone turning off build isolation but not having the C++ library available (devs can handle this case themselves if they wish). As a result, once Remove now unnecessary variable kvikio#466 is merged, the FIND_KVIKIO_CPP variable will be completely superfluous and we can remove that here.
  • As of Remove arrow dependency NVIDIA/cudf#16640 libcudf no longer links to libarrow and USE_LIBARROW_FROM_PYARROW is no longer used.
  • The libcudf and libcuspatial Python package builds in the devcontainer should (like all other Python packages) omit the CUDA version suffix. For that, they need to use the rapids_build_backend_args.

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 23, 2024
@vyasr vyasr self-assigned this Sep 23, 2024
@vyasr

vyasr commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

We can take this out of draft once rapidsai/kvikio#466 merges.

@vyasr
vyasr marked this pull request as ready for review September 23, 2024 19:49
@vyasr
vyasr requested a review from a team as a code owner September 23, 2024 19:49
@vyasr
vyasr requested review from KyleFromNVIDIA and removed request for a team September 23, 2024 19:49
@vyasr
vyasr merged commit 09757b6 into rapidsai:branch-24.10 Sep 23, 2024
@vyasr
vyasr deleted the fix/manifest_args branch September 23, 2024 21:25
vyasr added a commit that referenced this pull request Sep 23, 2024
I always forget this... For
#397 in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants