Repository navigation
add libkvikio wheel build to manifest - #283
Conversation
rapidsai/kvikio#369 moves the python wheel code one level deeper so that we add support for a dedicated libkvikio wheel. This adjustment needs to be accounted for here. Confused PR run without this change: https://github.com/rapidsai/kvikio/actions/runs/8900188332/job/24441209009#step:7:1446
|
I don't think this PR can pass without rapidsai/kvikio#369. @vyasr you wanted to merge this end of the loop first, right? Is it OK to merge with it failing here? If we want things to be passing prior to merging, then I think we have to approach it on the kvikio side with the part that we ripped out here: https://github.com/rapidsai/kvikio/pull/369/files#diff-1eb4e5fd5611777d4e597ef299a1cb5ba8050c28a2dabbd4fbc56205d69e5ddaR70-R72 then merge this devcontainers PR, then remove the stuff from kvikio. |
|
Yeah, one of these has to be merged while failing. Once the kvikio PR is passing all tests other than the devcontainer jobs, and once you have all the approvals that you need there, we can merge this PR and rerun tests a final time on that repo to make sure everything looks right before merging. |
msarahan
changed the title
|
@trxcllnt updated the kvikio path from rapidsai/kvikio#392 in #321 This PR now only adds an entry for building the cpp-only shared library wheel, which is utilized in rapidsai/kvikio#369 |
|
The kvikio PR has been merged. I'm going to close/reopen this PR to cycle CI and see where we stand. |
This is a step towards adding support for dynamic linking with wheels (splitting the shared libraries out into their own wheels). That's being tracked in rapidsai/build-planning#33 This PR performs a necessary step of moving the cuml folder one level deeper, such that the python folder becomes a parent of multiple full-fledged projects, instead of having the python folder be the top level of one python project. This is split into this PR because this change affects so many files. It's easier to review the actual changes of supporting the split wheel when you don't have to also consider these moves. This change also affects devcontainers, and there will need to be a change similar to rapidsai/devcontainers#283 for cuml. Authors: - Mike Sarahan (https://github.com/msarahan) - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - James Lamb (https://github.com/jameslamb) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5944
3 participants
rapidsai/kvikio#369 moves the python wheel code one level deeper so that we add support for a dedicated libkvikio wheel. This adjustment needs to be accounted for here. Confused PR run without this change: https://github.com/rapidsai/kvikio/actions/runs/8900188332/job/24441209009#step:7:1446