[msarahan]

This is a step towards adding support for dynamic linking with wheels (splitting the shared libraries out into their own wheels). That's being tracked in rapidsai/build-planning#33

This PR performs a necessary step of moving the cuml folder one level deeper, such that the python folder becomes a parent of multiple full-fledged projects, instead of having the python folder be the top level of one python project. This is split into this PR because this change affects so many files. It's easier to review the actual changes of supporting the split wheel when you don't have to also consider these moves.

This change also affects devcontainers, and there will need to be a change similar to rapidsai/devcontainers#283 for cuml.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[msarahan]

@bdice this has the same failures as the totally-unrelated #5943, so I think it might be ready for review. Let me know if I need to do anything to address the failures.

[msarahan]

closing/reopening to re-run CI

[jameslamb]

I did this:

git grep 'python/'

And see a few other places that should be changed

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/.github/CODEOWNERS#L10

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/ci/release/update-version.sh#L40-L44

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/ci/release/update-version.sh#L69

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/wiki/python/ESTIMATOR_GUIDE.md#L90

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/wiki/python/ESTIMATOR_GUIDE.md#L92

(not sure about this one):

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/docs/source/conf.py#L204

And then technically this one, although it looks like it's a leftover from an older state of these builds and actually isn't used for anything:

https://github.com/rapidsai/cuml/blob/751ba82f14df27f079ce5a542fb487f11430dd07/build.sh#L65

[KyleFromNVIDIA]

Fixed the remaining usages of python/.

[jameslamb]

Thanks, left 2 more small suggestions but otherwise this looks good to me. I don't need to re-review.

[trxcllnt]

We might also need to update these lines to use the containers with the new UCX version:

-      "BASE": "rapidsai/devcontainers:24.08-cpp-cuda11.8-ucx1.15.0-openmpi-ubuntu22.04"
+      "BASE": "rapidsai/devcontainers:24.08-cpp-cuda11.8-ucx1.17.0-openmpi-ubuntu22.04"

-      "BASE": "rapidsai/devcontainers:24.08-cpp-cuda12.2-ucx1.15.0-openmpi-ubuntu22.04"
+      "BASE": "rapidsai/devcontainers:24.08-cpp-cuda12.2-ucx1.17.0-openmpi-ubuntu22.04"

[dantegd]

python and cmake changes lgtm

[KyleFromNVIDIA]

/merge