Repository navigation
Remove the script/build.sh hook; rainix is the sole staged-config installer - #433
Merged
Merged
Conversation
…taller install-staged-config no longer skips when script/build.sh exists, and rainix-copy-artifacts no longer runs script/build.sh by presence. Repos that regenerate further committed artifacts declare the command through the regenerate-command input. Closes #418 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 26, 2026
Open
…ranch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418
install-staged-config:BUILD_HOOKand thescript/build.shskip are gone. It always installs.staged-config/.rainix-copy-artifacts: the step that ranscript/build.shbecause the file existed is gone. A repo that regenerates more committed artifacts afterforge build+CopyArtifacts.solnow declares the command through a newregenerate-commandinput. The command reaches the step throughenv, not${{ }}interpolation into the script. It is still teed into the codegen-declaration log.Consumer migration (default branches + S01-Issuer/st0x.deploy#518)
Each repo below has
script/build.shand callsrainix-copy-artifacts@main.graph codegen, bindings ABIs, test_fixtures.staged-config/is missing) and passregenerate-command. Until then its ABI and subgraph regen is not checkednix develop -c erc4626-words-preluderegenerate-command: ./script/build.sh. Until then the regen is not checkedrain-flare-preluderain meta build, Build.solrain meta buildcargo run --example emit-calldata-fixturegit add --intent-to-add --allregenerate-commandA workflow_call input that the reusable does not declare fails validation. So consumers can only pass
regenerate-commandonce this PR is merged.QA
a repo with script/build.sh has its staged config installeda repo with script/build.sh and nothing staged still failsderived artifacts regenerate from the declared input, never a file the repo happens to havescript/build.shskip back intoinstall_staged_config::run: killed by tests 10 and 11.if: hashFiles('script/build.sh') != ''on the regenerate step: killed by test 21.script/build.shon its default branch, and #518's head.BUILD_HOOK+ the skip tests, update the README. All four are done. The hook invocation in copy-artifacts is removed. Six consumers use it for regeneration, so the regen moves to an explicit input rather than being dropped.script/build.sh.cargo testin rainix-static (338 passed).batsfor install-staged-config + rainix-copy-artifacts (21/21 passed).pre-commit run --all-filesis clean.🤖 Generated with Claude Code