Skip to content

Skip validate-release on smoke builds - #220

Merged
ptr727 merged 2 commits into
developfrom
feature/smoke-skip-validate-release-219
Jun 27, 2026
Merged

Skip validate-release on smoke builds#220
ptr727 merged 2 commits into
developfrom
feature/smoke-skip-validate-release-219

Conversation

@ptr727

@ptr727 ptr727 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Problem

Closes #219. The validate-release entry gate (added in #213/#215) runs unconditionally, including in PR smoke builds. A smoke build checks out the PR head in detached HEAD, so NBGV always computes a prerelease version (X.Y.Z-g<sha>). On a main-base PR — a develop → main promotion carrying a build target — the gate's branch == 'main' arm fails:

::error::Public (main) release version 'X.Y.Z-g<sha>' carries a prerelease suffix; refusing to publish.

validate-release fails → build is skipped → the required Check pull request workflow status fails. Every clean develop → main promotion PR that includes a build-target change is blocked by its own smoke build (masked only when merged via admin bypass).

Fix

Skip the gate for smoke builds — they never publish — keeping the job in the graph as a success so build-*'s needs: [get-version, validate-release] stays satisfied:

          SMOKE: ${{ inputs.smoke }}
          ...
          if [[ "$SMOKE" == "true" ]]; then
            echo "Smoke build; skipping release version validation."
            exit 0
          fi

Real publishes (smoke: false) still get both-direction validation.

Verification

  • actionlint (Docker, shellcheck-bundled) clean; CRLF preserved.
  • Per the issue's push-probe: a smoke: true invocation passes for both branch: main (Release) and branch: develop (Debug) with github-release skipped; real publishes unaffected.

Found via end-to-end CI flow validation during the #213/#214 downstream re-sync.

🤖 Generated with Claude Code

Fixes #219. The validate-release gate ran unconditionally, including in PR
smoke builds. A smoke build checks out the PR head in detached HEAD, so NBGV
always computes a prerelease version (X.Y.Z-g<sha>). On a main-base PR (a
develop->main promotion carrying a build target) the gate's branch==main arm
then fails ("public release version carries a prerelease suffix"), the build
job is skipped, and the required Check pull request workflow status fails -
blocking every clean develop->main promotion that includes a build change.

Skip the gate for smoke builds (they never publish), keeping the job in the
graph as a success so build-*'s `needs: [get-version, validate-release]` stays
satisfied.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 27, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the reusable release build workflow so the validate-release entry gate does not fail PR smoke builds (which run in detached HEAD and therefore always produce an NBGV prerelease SemVer2), unblocking clean develop -> main promotion PRs that include build-target changes.

Changes:

  • Passes inputs.smoke into the validate-release step via SMOKE env var.
  • Early-exits the validate-release script successfully when running in smoke mode, while keeping the job in the DAG so dependent build jobs' needs: remain satisfied.

Comment thread .github/workflows/build-release-task.yml Outdated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727
ptr727 merged commit 70025b2 into develop Jun 27, 2026
8 checks passed
@ptr727
ptr727 deleted the feature/smoke-skip-validate-release-219 branch June 27, 2026 00:20
ptr727 added a commit that referenced this pull request Jul 4, 2026
Promote the accumulated `develop` work to `main`. Twelve changes since
the last promotion:

- Add `WORKFLOW.md`: workflow style, architecture, behavioral contract,
test methodology (#223)
- Use NBGV `IGNORE_GITHUB_REF` instead of the ineffective `GITHUB_REF`
override (#222)
- Skip validate-release on smoke builds (#220)
- Gate asset delete on the release create/refresh condition (#218)
- Ship branch rulesets as versioned JSON in the re-sync / drift loop
(#212)
- Clean up transfer artifacts surgically at consumption, not
blanket-delete (#216)
- Version each publish leg against its own branch; validate at entry
(#215)
- Consolidate workspace configurations into a unified ProjectTemplate
workspace (#210)
- Template convergence barrier: absorb pins, generic release +
docker-readme, carry-whole-file (#207)
- Key merge-bot concurrency on PR number, not `github.ref` (#206)
- Codify orchestrated re-sync personas and full-replacement rule (#205)
- Lead action pins; affirm pattern-based artifact handoff (#204)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants