Skip to content

Gate asset delete on the release create/refresh condition - #218

Merged
ptr727 merged 1 commit into
developfrom
feature/gate-asset-delete-on-release-217
Jun 26, 2026
Merged

Gate asset delete on the release create/refresh condition#218
ptr727 merged 1 commit into
developfrom
feature/gate-asset-delete-on-release-217

Conversation

@ptr727

@ptr727 ptr727 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Problem

Closes #217. In build-release-task.yml's github-release job the two paired steps had mismatched conditions:

  • Create GitHub release stepif: exists == 'false' || workflow_dispatch
  • Delete consumed release asset artifacts stepif: expect_release_assets

On a scheduled run where the release tag already exists (no new commits), the create step is skipped but build-nugetlibrary still uploaded release-asset-<branch>-*, so the delete step removed the freshly built artifacts even though nothing was published/refreshed this run. Low impact (retention-days: 1 means nothing is permanently lost) but the delete's premise ("durable copies now on the release") doesn't hold for that run.

Fix

Gate the delete on the same condition as the create step:

        if: ${{ inputs.expect_release_assets && (steps.release-exists.outputs.exists == 'false' || github.event_name == 'workflow_dispatch') }}

So it only deletes when a release was actually created/refreshed; otherwise the fresh artifacts stay for the run and retention-days: 1 reaps them.

Surfaced via Copilot during the downstream re-sync of #213/#214 (ptr727/LanguageTags#195) and reported upstream rather than diverged locally.

Verification

  • actionlint (Docker) clean; CRLF preserved.

🤖 Generated with Claude Code

Fixes #217. The github-release job's "Delete consumed release asset artifacts"
step gated only on expect_release_assets, but the "Create GitHub release" step
also gates on exists=='false' || workflow_dispatch. On a scheduled re-run where
the tag already exists, create is skipped but the freshly built
release-asset-<branch>-* artifacts were still deleted, even though nothing was
published/refreshed this run. Gate the delete on the same condition so it only
runs when a release was actually created/refreshed; otherwise retention-days:1
reaps the artifacts at end of run.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 26, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the build-release-task.yml reusable workflow so the cleanup step that deletes release-asset-<branch>-* workflow artifacts is gated by the same condition as the GitHub release creation/refresh step, avoiding deletion on no-op scheduled runs where the tag already exists.

Changes:

  • Gate the "Delete consumed release asset artifacts" step on (release does not exist) OR (manual refresh condition), matching the create-release step logic.
  • Expand the surrounding comment to document why the delete is now gated.

Comment thread .github/workflows/build-release-task.yml
@ptr727
ptr727 merged commit 8d508ce into develop Jun 26, 2026
9 checks passed
@ptr727
ptr727 deleted the feature/gate-asset-delete-on-release-217 branch June 26, 2026 19:25
ptr727 added a commit to ptr727/LanguageTags that referenced this pull request Jun 26, 2026
…condition

Pull down the template fix for the edge case reported as ProjectTemplate#217:
the surgical delete step now gates on the same
`exists=='false' || workflow_dispatch` condition as the create step, so a
scheduled re-run on an existing tag no longer deletes the freshly built
artifacts (retention-days: 1 reaps them instead). Re-synced verbatim from
template PR ptr727/ProjectTemplate#218, which also clears the condensed-comment
drift from the original #195 snippet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727 added a commit that referenced this pull request Jul 4, 2026
Promote the accumulated `develop` work to `main`. Twelve changes since
the last promotion:

- Add `WORKFLOW.md`: workflow style, architecture, behavioral contract,
test methodology (#223)
- Use NBGV `IGNORE_GITHUB_REF` instead of the ineffective `GITHUB_REF`
override (#222)
- Skip validate-release on smoke builds (#220)
- Gate asset delete on the release create/refresh condition (#218)
- Ship branch rulesets as versioned JSON in the re-sync / drift loop
(#212)
- Clean up transfer artifacts surgically at consumption, not
blanket-delete (#216)
- Version each publish leg against its own branch; validate at entry
(#215)
- Consolidate workspace configurations into a unified ProjectTemplate
workspace (#210)
- Template convergence barrier: absorb pins, generic release +
docker-readme, carry-whole-file (#207)
- Key merge-bot concurrency on PR number, not `github.ref` (#206)
- Codify orchestrated re-sync personas and full-replacement rule (#205)
- Lead action pins; affirm pattern-based artifact handoff (#204)

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants