SET-1223: restructure into per-package uv projects - #768
Conversation
nevoodoo
changed the title
f5c3089 to
2b1c062
Compare
2b1c062 to
8f7de7a
Compare
dancoates
left a comment
dancoates
left a comment
There was a problem hiding this comment.
Looks good, just a few comments, mostly on the sort of comments that claude loves to leave in which call out implementation details that are part of the migration but not particularly interesting to the project long term and don't need to be included as a permanent comment.
| @@ -0,0 +1,89 @@ | |||
| name: SBOM Upload | |||
There was a problem hiding this comment.
I'm not against having this, but it belongs in a separate PR to this one
| # The server image builds FROM the Hail driver image (see Dockerfile), which runs | ||
| # Python 3.11. | ||
| # | ||
| # NOTE: this is a deployed application, not a published package, so there is |
There was a problem hiding this comment.
I don't think we need this note, I think it is pretty clear that a server doesn't need a build system
| [tool.pytest.ini_options] | ||
| testpaths = ["test"] | ||
| [tool.ruff.lint.per-file-ignores] | ||
| # Rules stabilised in ruff 0.16 that flag package files this migration must |
There was a problem hiding this comment.
Comments shouldn't refer to a point in time action like a migration
| @@ -1,3 +1,27 @@ | |||
| # Thin, non-package root project. | |||
There was a problem hiding this comment.
This comment duplicates info from the README, and is unncessary extra detail. This sort of monorepo structure is common and doesn't need to be called out like this.
8f7de7a to
922b8c4
Compare
2 participants
Second half of SET-1223, stacked on #767.
Moves everything into packages/:
Each is an independent uv project with its own lockfile and not a uv workspace, since they need conflicting dependencies. Version bumps now use
uv versioninstead of bump2version.The published package is unchanged (verified by comparing wheels built from main and from this branch), apart from
_version.pywhich now reads the version from package metadata. It matches the 3.3.0 release, so merging publishes nothing.A stub stays at
analysis_runner/_version.pyso old CLIs' update check keeps working; SET-1255 tracks removing it.