SET-1223: toolchain prep - #767
Open
nevoodoo wants to merge 10 commits into
Open
Conversation
nevoodoo
changed the title
nevoodoo
marked this pull request as ready for review
August 6, 2026 11:12
nevoodoo
force-pushed
the
set-1223-pr1-toolchain-prep
branch
from
August 12, 2026 01:15
faf8a52 to
3b65196
Compare
jmarshall
reviewed
Aug 12, 2026
|
|
||
|
|
||
| def copy_outputs_to_bucket( | ||
| def copy_outputs_to_bucket( # noqa: PLR0917 |
Contributor
There was a problem hiding this comment.
This is added a few times. Should we suppress this one, or raise the limit via lint.pylint.max-positional-args?
Contributor
There was a problem hiding this comment.
I think it would be good keep the limit fairly low to discourage future methods that have heaps of args, not against raising it above 5 though, 10 feels too high, 7 or 8?
…ical Makefile route)
nevoodoo
force-pushed
the
set-1223-pr1-toolchain-prep
branch
from
August 16, 2026 05:57
3b65196 to
013aed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First half of SET-1223. This is the in-place toolchain cleanup before the repo restructure, which will come in a follow-up PR.
Tests now run with
pytest(the tests themselves are stillunitteststyle, just the runner changed). Linting is ruff only now and the oldpylint/flake8configs are gone,ruffis bumped to 0.16 and its fixes are applied across scripts, server, web and the tests. Pre-commit hooks are bumped to latest and all the GitHub actions are pinned to commit SHAs.setup.py,analysis_runner/and.bumpversion.cfgare identical to main and the version hasn't changed, so merging this won't publish anything to PyPI. One thing to be aware of: ruff 0.16added some new rules that flag existing code inanalysis_runner/`, which this PR deliberately doesn't touch, so the ruff hook skips that directory for now. The restructure PR will swap that for per-file ignores and bring back full lint coverage of the package.