Repository navigation
Conversation
…s drop "Until" (pingdotgg#29134) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#29980) * fix(web): project location keeps its machine name when the path truncates
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This refactors voice-input startup for React Compiler compatibility while retaining existing polling, cancellation checks, and pending-request cleanup. It introduces no product-default changes or broader recording or data access. You can add or adjust custom eligibility rules. Learn more. |
6df74fc to
715b561
Compare
|
Note Written by Merged the rebased Checked on a testbox:
|
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 5 (#28844).
Problem
#30437 added a
try … finallytostartinuseEnvironmentSpeechInput.ts. The React Compiler can't compile afinallyclause, so it skips the whole hook andreactCompilerCoverage.test.tsfailsTest Webon this layer and every PR stacked above it.Change
The awaited status check (and the wait while a previous stream is still transcribing) moves into a small
waitForStatushelper insidestart. It returnsnullwhen the start is no longer current, which covers the early returns that used to sit in thetry.startnow clearspendingStartRefonce in thecatchand once right after thetry, so every exit path still clears it. No behavior change.Scope and approval
A small fix to a CI failure that #30437 introduced on Maria's redesign stack. It touches one function and changes no behavior.
Verification
vp test run apps/web/src/reactCompilerCoverage.test.ts -t useEnvironmentSpeechInput: failed on the layer with thefinallybailout, passes now.vp test run apps/web/src/speech/: 7 files, 30 tests pass, including "cancels a start that is still checking the environment".vp run check:changed origin/maria/redesign/5-voice: format, lint, knip, typecheck, tests and React compiler all pass.Made with Claude Opus 5.5 in Claude Code (via T3 Code).