Skip to content

fix(web): settings stay dark in the Iris, Ember, Ocean and Grove themes - #29278

Merged
maria-rcks merged 1 commit into
pingdotgg:maria/redesign/4-settings-setupfrom
flamboh:t3/redesign-fix-builtin-theme-settings-panel
Nov 2, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:maria/redesign/4-settings-setupfrom
flamboh:t3/redesign-fix-builtin-theme-settings-panel

Conversation

@flamboh

@flamboh flamboh commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 4 (#28842).

In dark mode, the Iris, Ember, Ocean and Grove themes turned the Settings panel a pale grey that looked almost like light mode. The panel was much lighter than its own sidebar, and the cards on it were darker than the panel. T3 Code, T3 Chat and imported themes looked fine.

The panel used the theme's menu color (surfaceOverlay). These four themes make that color far lighter than the page (about +0.16 OKLCH lightness) so small menus stand out. T3 Chat sets it equal to its surface color, so it never showed the problem.

Now the panel uses the theme's surface color, the same color its cards use. Every theme's panel now sits one small step above the settings sidebar, like the default theme (#0f0f0f sidebar, #171717 panel). T3 Chat's dark panel doesn't change, and light-mode panels move by less than 0.01 lightness.

Theme (dark) Sidebar L Panel L before Panel L after
Iris 0.226 0.387 0.251
Ember 0.246 0.401 0.270
Ocean 0.243 0.399 0.267
Grove 0.261 0.411 0.285
T3 Chat 0.228 0.267 0.267

Before / after

Settings → Appearance with Iris, dark. Left: layer 4. Right: this PR.

Iris dark: on layer 4 the Settings panel is pale lavender and lighter than its cards; with this PR the panel is dark and the cards sit on it

Every built-in theme, main vs layer 4 vs this PR:

Dark grid: Iris, Ember, Ocean and Grove panels are pale on layer 4 and dark with this PR; T3 Code and T3 Chat are unchanged

Light grid: panels change by less than 0.01 lightness

Validation

  • Measured the computed sidebar and panel colors for every built-in theme, dark and light, before and after, in a local dev build.
  • vp run check:changed origin/maria/redesign/4-settings-setup passes.

Made with Claude Opus 5.5 in Claude Code.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 58a5817

Macroscope's review found this PR approvable — Settings panels now use the selected theme’s card surface rather than its popover color. The change is limited to visual styling and leaves settings behavior and product defaults unchanged.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks

maria-rcks commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

Verified exact head 58a5817f030e0deabba17b45b6c2b426aac76467 on a disposable Linux VM with repo Playwright and /usr/bin/google-chrome. Ran vp i and background vp run dev, with one dev server at a time and isolated state. Created the project through the app using the real repository and completed Codex gpt-6.1-sol turns through the web composer on main and this head. No mocks or seeded demo data.

Checked github/main at 84537c4dd9 first: the pale panel does not reproduce there. It reproduces on this PR's redesign base 31209e11c1. Reused the same app-created data for the base/head comparison.

Settings > Appearance > Dark > Iris reproduces the pale panel on the base (OKLCH lightness 0.387). This head renders it dark at 0.251. Clicked through all six built-in themes in dark and light modes. Dark panel lightness: Iris 0.251, Ember 0.271, Ocean 0.268, Grove 0.286; each matches its card surface. T3 Chat stays at 0.267. T3 Code remains #171717 with #0f0f0f sidebar. Light panels remain light.

Also checked settings navigation, the project-order dropdown, close/reopen, theme persistence after reload, and the panel at 1440x1000 and 1000x800. A follow-up real Codex turn completed and remained visible after reload.

Scoped validation through Blacksmith:

vp run check:changed 31209e11c185537102c60bf603347ffe2f99ebb2
1 changed file
format: pass
typecheck (web + scripts): pass

No code changes were needed. Existing PR CI is green.

Main baseline:

main, Iris dark settings

Before, redesign base:

before: pale Iris settings panel on the redesign base

After, exact PR head:

after: dark Iris settings panel on the PR head

completed real Codex gpt-6.1-sol turns in the web client

Not verified

Native Electron, iOS and Android clients; macOS/Windows rendering; imported custom themes; remote relay/tunnel connections. This pass exercised the Linux dev web client against its running server and real Codex provider. It makes no performance claim.

@maria-rcks
maria-rcks merged commit ceaae08 into pingdotgg:maria/redesign/4-settings-setup Nov 2, 2026
31 checks passed
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 3, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 3, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 4, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 4, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 4, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 4, 2026
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 4, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants