Repository navigation
fix(web): settings stay dark in the Iris, Ember, Ocean and Grove themes - #29278
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Settings panels now use the selected theme’s card surface rather than its popover color. The change is limited to visual styling and leaves settings behavior and product defaults unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
Note Written by Verified in a real dev environmentVerified exact head Checked Settings > Appearance > Dark > Iris reproduces the pale panel on the base (OKLCH lightness 0.387). This head renders it dark at 0.251. Clicked through all six built-in themes in dark and light modes. Dark panel lightness: Iris 0.251, Ember 0.271, Ocean 0.268, Grove 0.286; each matches its card surface. T3 Chat stays at 0.267. T3 Code remains #171717 with #0f0f0f sidebar. Light panels remain light. Also checked settings navigation, the project-order dropdown, close/reopen, theme persistence after reload, and the panel at 1440x1000 and 1000x800. A follow-up real Codex turn completed and remained visible after reload. Scoped validation through Blacksmith: No code changes were needed. Existing PR CI is green. Main baseline: Before, redesign base: After, exact PR head: Not verifiedNative Electron, iOS and Android clients; macOS/Windows rendering; imported custom themes; remote relay/tunnel connections. This pass exercised the Linux dev web client against its running server and real Codex provider. It makes no performance claim. |
ceaae08
into
pingdotgg:maria/redesign/4-settings-setup




Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 4 (#28842).
In dark mode, the Iris, Ember, Ocean and Grove themes turned the Settings panel a pale grey that looked almost like light mode. The panel was much lighter than its own sidebar, and the cards on it were darker than the panel. T3 Code, T3 Chat and imported themes looked fine.
The panel used the theme's menu color (
surfaceOverlay). These four themes make that color far lighter than the page (about +0.16 OKLCH lightness) so small menus stand out. T3 Chat sets it equal to its surface color, so it never showed the problem.Now the panel uses the theme's surface color, the same color its cards use. Every theme's panel now sits one small step above the settings sidebar, like the default theme (
#0f0f0fsidebar,#171717panel). T3 Chat's dark panel doesn't change, and light-mode panels move by less than 0.01 lightness.Before / after
Settings → Appearance with Iris, dark. Left: layer 4. Right: this PR.
Every built-in theme, main vs layer 4 vs this PR:
Validation
vp run check:changed origin/maria/redesign/4-settings-setuppasses.Made with Claude Opus 5.5 in Claude Code.