[t3dotgg]

Toggling a scheduled task in Settings > Scheduled Tasks moved it to the top of the list. The row above slid under the pointer, so the next click could toggle a different task.

Takeover of #21450 by @only21mil. Their commit is kept with its authorship. I only added the ManagedProjectFolders test layer that main now requires, so the new test runs.

The list query sorts by created_at DESC instead of updated_at DESC. Toggles, runs, and edits rewrite updated_at, but nothing changes created_at after insert, so rows keep their place and new tasks still show first. Web settings, the thread Automations section, mobile settings, and list_scheduled_tasks all read this one list. listDueTasks keeps its own next_run_at order, so dispatch order does not change.

Proof: the new test in ScheduledTaskService.schedule.test.ts fails with main's service file (received [older, newer] after the toggle) and passes here. vp test run src/scheduledTasks/ (7 files, 74 tests) and vp run check:changed pass. I did not run the app; the original PR has real web, iOS, and Android before/after screenshots.

Closes #16390

Made by Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The change is a narrowly scoped scheduled-task ordering fix with regression coverage, switching the list from update-time ordering to stable creation-time ordering while leaving dispatch ordering unchanged. Because this changes the default ordering users see in the product, it warrants review under the repository's approval policy.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	4.9 KiB	5.0 KiB	+23 B (+0.5%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+23 B (+1.9%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.8 KiB	20.9 KiB	+41 B (+0.2%)	29.3 KiB	✅
Codex	Live turn messages	1	2	+1 (+100.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: e822ba7 · PR result: e30cd87 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 2e1e1734-3c7d-4d0f-9e54-fd15322da47f

📥 Commits

Reviewing files that changed from the base of the PR and between e822ba7 and e30cd87.

📒 Files selected for processing: 2

• apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts
• apps/server/src/scheduledTasks/ScheduledTaskService.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The scheduled-task list now orders tasks by created_at DESC, task_id ASC instead of mutable updated_at. An integration test verifies that toggling or editing a task does not change its position.

Changes: Scheduled-task list ordering

Layer / File(s)	Summary
Stable ordering and regression test apps/server/src/scheduledTasks/ScheduledTaskService.ts, apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts	The list query uses creation time and task ID for ordering. The integration test confirms that toggling and editing an older task do not reorder the list.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to e30cd

The change appears ready to merge after normal checks. Confirm the intended sort direction if the linked issue’s oldest-first proposal is still required.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly describes the primary fix: scheduled tasks no longer move to the top when toggled. It uses a concise conventional commit format.
Description check		The description covers the problem, implementation, scope, affected list consumers, verification results, limitations, issue reference, and agent metadata. It is sufficiently complete for the required…
Linked Issues check		Issue [#16390] requires a scheduled task toggle to keep the task in the same visual position. ScheduledTaskService.selectAllRows now orders by immutable created_at DESC, task_id ASC instead of mut…
Out of Scope Changes check		The pull request changes only the scheduled-task list ordering and adds a regression test for toggle and edit stability. Both changes directly support issue [#16390]. No unrelated product behavior or …

Full details: Description check

Explanation

The description covers the problem, implementation, scope, affected list consumers, verification results, limitations, issue reference, and agent metadata. It is sufficiently complete for the required template.

Full details: Linked Issues check

Explanation

Issue [#16390] requires a scheduled task toggle to keep the task in the same visual position. ScheduledTaskService.selectAllRows now orders by immutable created_at DESC, task_id ASC instead of mutable updated_at. The added test creates two tasks and verifies the order after setEnabled and an edit rewrite updated_at. The separate listDueTasks query retains next_run_at ordering. The issue's proposed ASC direction is not required by its expected behavior; the current DESC order also remains stable and keeps new tasks first.

Full details: Out of Scope Changes check

Explanation

The pull request changes only the scheduled-task list ordering and adds a regression test for toggle and edit stability. Both changes directly support issue [#16390]. No unrelated product behavior or unrelated files are included in the reviewed diff.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}