[nabettu]

Problem

On iOS, opening some pull requests (for example #21548) immediately replaces the screen with "This screen couldn't be displayed" and Maximum update depth exceeded. The component stack points at AnimatedLegendList inside PullRequestRouteScreen. The setState comes from LegendList's useImperativeHandle cleanup calling the combined ref with null, which runs setLegendList in AnimatedLegendList.

Change

The Overview / Guide / Activity tab lists each got an inline ref={(list) => ...} inside the tab .map(). The React Compiler can't memoize closures created per map iteration, so every render of the screen passed new refs. AnimatedLegendList folds its ref into a combined ref, so a new ref makes LegendList detach and re-attach its imperative handle. Each time, it sets state twice during commit (null, then a fresh handle object). Those nested sync updates stack up with the screen's own re-renders until React stops.

Each tab now gets a stable ref callback created once in a useState initializer. The other AnimatedLegendList call sites already pass stable refs.

Scope and approval

This is a very small, focused fix for an obvious crash. It's one file, the refs still write the same scrollViews entries, and it doesn't change behavior. There's no prior issue.

Verification

• I confirmed the cause against the Release bundle that crashed: the compiled screen creates ref: list => { scrollViews.current[tab_0] = list; } on every render, and the error stack goes through imperativeHandleEffect cleanup → useCombinedRef → setLegendList.
• I built this branch as an iOS Release build, installed it on an iPhone, and opened the same pull request. It renders, and switching between Overview and Activity works without the error.
• src/reactCompilerCoverage.test.ts passes, so the screen still compiles with the React Compiler. Mobile tsc passes.
• I didn't add an automated test: rendering this screen under jsdom would mean mocking Reanimated and LegendList, and the test wouldn't exercise the real ref behavior.

Done with Claude Opus 5.5 in Claude Code (via T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 7f8d7a9

Macroscope's review found this PR approvable — This one-file mobile fix stabilizes the three pull-request list refs, preventing AnimatedLegendList ref churn from triggering the update-depth crash. Existing tab scrolling and handle storage remain unchanged, with no product-default or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: db073d89-a100-44a3-90fc-3bfc75f19c0b

📥 Commits

Reviewing files that changed from the base of the PR and between 569bd02 and 7f8d7a9.

📒 Files selected for processing: 1

• apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The pull request screen now creates stable list ref callbacks for its overview, guide, and activity tabs. Each AnimatedLegendList receives the callback for its tab.

Changes: Pull request tab list refs

Layer / File(s)	Summary
Create and use stable list refs apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx	The screen creates callbacks for the overview, guide, and activity tabs that store list handles in scrollViews.current. Each AnimatedLegendList uses the matching callback.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 7f8d7

The ref lifecycle change preserves tab scrolling behavior and addresses the reported rerender loop.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: fixing the mobile crash caused by opening a pull request.
Description check		The description covers the problem, root cause, implementation, scope justification, verification results, and limitations. It is complete enough for review, although it does not include UI screenshot…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description covers the problem, root cause, implementation, scope justification, verification results, and limitations. It is complete enough for review, although it does not include UI screenshots requested by the template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}