Skip to content

perf(parser): table-driven operator precedence lookup#23346

Merged
graphite-app[bot] merged 1 commit into
mainfrom
perf/parser-precedence-table
Jun 12, 2026
Merged

perf(parser): table-driven operator precedence lookup#23346
graphite-app[bot] merged 1 commit into
mainfrom
perf/parser-precedence-table

Conversation

@Boshen

@Boshen Boshen commented Jun 12, 2026

Copy link
Copy Markdown
Member

kind_to_precedence is called for every token while parsing binary expressions; replace the branchy match with a 256-entry lookup table indexed by Kind discriminant.

Interleaved A/B benchmark (12 alternating runs, medians) showed ~-1.3% on binder.ts from this change alone. Conformance and snapshots unchanged.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the A-parser Area - Parser label Jun 12, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1


Comparing perf/parser-precedence-table (ad1844b) with main (6e516f7)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen force-pushed the perf/parser-precedence-table branch from fafc14d to ad1844b Compare June 12, 2026 14:11
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 12, 2026

Boshen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Merge activity

@Boshen

Boshen commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Comparing the generated assembly (aarch64, release) of the table version vs the original match:

Table — 4 instructions, zero branches:

and   x8, x0, #0xff          ; kind as usize
adrp  x9, PRECEDENCE_TABLE@PAGE
add   x9, x9, ...@PAGEOFF
ldrb  w0, [x9, x8]           ; one byte load
ret

Original match — LLVM already lowers it to a jump table, but a heavier one:

and   w8, w0, #0xff
mov   w0, #23                ; preload None
sub   w8, w8, #25            ; range check
cmp   w8, #119
b.hi  default                ; branch 1
adrp  x9, LJTI...
ldrb  w11, [x9, x8]
add   x10, x10, x11, lsl #2
br    x10                    ; branch 2 (indirect)
mov   w0, #13                ; one of ~12 mov/ret blocks
ret

Both are table-driven, but the match's table holds code offsets requiring an indirect br into ~12 separate mov/ret blocks, while the new table holds the answers directly. Token sequences are effectively random to the branch predictor, so that indirect branch mispredicts frequently in the hot binary-expression loop; the data table is a single branchless byte load (256 bytes = 4 cache lines, stays L1-hot). That's where the ~1.3% comes from.

Caveat: native-only. On wasm both versions compile to roughly equivalent br_table constructs (wasm binary delta is +44 bytes), so the gain there is likely much smaller.

`kind_to_precedence` is called for every token while parsing binary expressions; replace the branchy `match` with a 256-entry lookup table indexed by `Kind` discriminant.

Interleaved A/B benchmark (12 alternating runs, medians) showed ~-1.3% on binder.ts from this change alone. Conformance and snapshots unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the perf/parser-precedence-table branch from ad1844b to 2783295 Compare June 12, 2026 14:32
@graphite-app graphite-app Bot merged commit 2783295 into main Jun 12, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 12, 2026
@graphite-app graphite-app Bot deleted the perf/parser-precedence-table branch June 12, 2026 14:36
Boshen added a commit that referenced this pull request Jun 15, 2026
### 💥 BREAKING CHANGES

- 7a24911 codegen: [**BREAKING**] Borrow sourcemaps from codegen
(#23422) (Boshen)
- bb0ed44 transformer: [**BREAKING**] Disable styled-components
transpileTemplateLiterals by default (#23171) (Boshen)

### 🚀 Features

- 1490a0a linter/react: Implement react-compiler rule (#23202) (Boshen)
- 6c0bdf0 transformer/react-refresh: Support `module.property.useHook()`
(#23190) (Dunqing)
- 47991bd semantic: Report TS1228 for invalid type predicates (#23174)
(camc314)
- 1d3af58 parser: Add TS2398 parameter property diagnostic (#23216)
(camc314)
- 44313da semantic: Add `scope_is_descendant_of` api (#22313) (camc314)
- e5050c0 parser: Improve diagnostic for rest initializer (#23205)
(camc314)
- ec266bb transformer: Run React Compiler as a feature-gated transform
pass (#23201) (Boshen)
- e7374fe parser: Report error for `const` modifier on interface type
parameter (#23173) (camc314)
- a7c1c9b parser: Report ambient definite variable assertions (#23165)
(camc314)
- d169fcd parser: Report invalid class definite assertions (#23164)
(camc314)
- 00244d8 parser: Report definite property initializer errors (#23160)
(camc314)

### 🐛 Bug Fixes

- 52d0c31 transformer: Replace ambient dot defines (#23231) (camc314)
- 2c28748 transformer/class: Parent generated constructors to class
scope (#23222) (camc314)
- 8edd234 parser: Report accessor definite assertion on token (#23203)
(camc314)
- de38a3f react_compiler: Keep imports referenced only by a local
re-export (#23176) (Boshen)
- f5721c2 codegen: Preserve parentheses around `intrinsic` type
reference (#23156) (Boshen)
- e89f81d parser: Don't emit TS1477 for parenthesized instantiation
expression (#23147) (Boshen)
- 8a04149 parser: Reject module-referencing imports/exports in a
namespace body (#22829) (Boshen)

### ⚡ Performance

- 2783295 parser: Table-driven operator precedence lookup (#23346)
(Boshen)
- 231d5de parser: Single-match member expression dispatch (#23347)
(Boshen)
- e89729b codegen: Accept one-shot wrap closures (#23265) (camc314)
- a6c11fa parser: Force-inline read_non_decimal to fold per-digit number
dispatch (#23157) (Boshen)
- d74964c parser: Store class definite assertion offset (#23170)
(camc314)
- f0fda4d parser: Shrink-wrap cold diagnostic tails out of hot frames
(#23159) (Boshen)
- a082180 parser: Store definite assertion offset (#23167) (camc314)
- 534f9c6 oxc: Conditionally rebuild semantic in compiler pipeline
(#23153) (Boshen)
- b435c6a parser: Skip checkpoint for `infer T extends U` constraint in
disallow context (#23128) (Boshen)
- 7464dce parser: Peek instead of checkpoint/rewind for `export default`
modifier (#23124) (Boshen)
- 80a9a32 parser: Fast-path single-keyword TS declarations (#23083)
(Boshen)
- da1a6c6 diagnostics: Migrate to allocation-optimized oxc-miette
(#23094) (Boshen)
- b7b08ce parser: Peek once for the static modifier disambiguation
(#23079) (Boshen)
- e7e07a3 parser: Fold unary dispatch into a single match (#23076)
(Boshen)

### 📚 Documentation

- d241add semantic: Add `AGENTS.md` test guidance for agents (#23441)
(camc314)
- 026f1ae parser: Add `AGENTS.md` test guidance for agents (#23440)
(camc314)
- 09755ac transformer: Add `AGENTS.md` test guidance for agents (#23439)
(camc314)
- e6bdfd4 lexer: Correct reference link for `byte_handlers!` (#23313)
(Dunqing)
- 65b6d7a allocator: Fix memory leaks in `Arena` examples (#23257)
(overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant