fix(parser): report accessor definite assertion on token

[camc314]

Summary

• Pass the definite-assignment assertion token offset through the class accessor-property parser path.
• Report invalid ambient and abstract accessor prop! diagnostics on the ! token, matching the span behavior used by variable declarators and normal class properties.
• Add focused misc parser coverage for the accessor-specific invalid cases.

Rationale

This follows up #23170. That parser change already narrowed definite-assignment diagnostics for variables and normal class properties, but accessor properties still kept only a boolean. That meant accessor prop! could only report TS1255 using the full class element span. Carrying the offset into parse_class_accessor_property aligns accessor diagnostics with the other definite-assignment diagnostics and keeps the AST shape unchanged by storing only definite.is_some().

The misc fixture is needed because upstream TypeScript coverage exercises invalid definite assertions on normal fields, but not invalid accessor properties. Existing misc coverage only had a valid accessor y! pass case, so just coverage did not specifically protect the accessor diagnostic span this fixes.

[codspeed-hq]

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks¹

---

_{Comparing codex/fix-accessor-definite-offset (e9f1daf) with main (3de589a)}

Footnotes

1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

Aligns TypeScript definite-assignment assertion (!) diagnostics for class accessor properties with existing span behavior for variable declarators and normal class properties by reporting TS1255 on the ! token rather than the full class element span.

Changes:

• Thread the definite-assignment assertion token start offset (Option<u32>) through the class accessor-property parsing path and emit TS1255 using a 1-character span on !.
• Keep the AST shape unchanged by continuing to store only definite.is_some() on the accessor property node.
• Add misc negative coverage for invalid accessor prop! in ambient and abstract contexts, and update the parser misc snapshot.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_parser/src/js/class.rs	Carries the ! token start offset into parse_class_accessor_property and reports TS1255 on a sized span targeting the !.
tasks/coverage/misc/fail/oxc-23170.ts	Adds focused failing TypeScript inputs covering ambient and abstract accessor-property definite assertions.
tasks/coverage/snapshots/parser_misc.snap	Updates snapshot to include the two new TS1255 diagnostics and adjusts negative test counts accordingly.

[camc314]

Merge activity

• Jun 10, 7:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jun 10, 7:46 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Jun 10, 7:50 AM UTC: Merged by the Graphite merge queue.