fix(parser): don't emit TS1477 for parenthesized instantiation expression

[Boshen]

oxc_parser emitted TS1477 ("An instantiation expression cannot be followed by a property access") for parenthesized instantiation expressions such as (a<b>).c when preserve_parens: false (the mode oxfmt and oxlint use). tsc and Babel accept it — only the unparenthesized form is an error.

The old check keyed off lhs being a TSInstantiationExpression, but the ParenthesizedExpression wrapper that distinguishes (a<b>).c from a<b>.c is dropped when preserve_parens is off, so the bare instantiation leaked through.

Fix

Emit TS1477 only when the instantiation expression is not parenthesized. Instead of relying on a ParenthesizedExpression node surviving the AST, detect it by span: an instantiation built in the member-expression loop starts at lhs_span, while one unwrapped from a stripped paren starts past the (. A shared helper covers both the property-access (.) and element-access ([) branches.

source	result	notes
a<b>.c	TS1477
a<b>?.[c]	TS1477	element access on a bare instantiation
a?.b<c>.d	TS1477
(a<b>).c	ok	the fix
(a<b>)[c] / (a<b>)?.[c]	ok	the fix
(a).b<c>.d	TS1477	parens wrap a, not the instantiation

Correct regardless of preserve_parens; under the default (true) behavior is unchanged, so no conformance snapshots move.

Note: tsc only checks property access (parsePropertyAccessExpressionRest), so it does not flag a<b>?.[c] — an apparent oversight, since accessing a member of an instantiation expression is the same operation either way. Babel flags both, and this PR keeps oxc's existing behavior for the unparenthesized element-access case.

Closes #23133.

Alternative to #23135 (same issue, same resulting behavior). That PR records parenthesized instantiation expressions in a new ParserState set; this one derives the same fact from spans, needing no extra parser state.

🤖 Generated with Claude Code

[codspeed-hq]

Merging this PR will not alter performance

✅ 57 untouched benchmarks
⏩ 14 skipped benchmarks¹

---

_{Comparing fix-ts1477-parenthesized-instantiation (b20c584) with main (e78e75b)²}

Footnotes

1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (8ab6ee1) during the generation of this report, so e78e75b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c78c0c327

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Boshen]

Merge activity

• Jun 9, 10:30 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jun 9, 10:33 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Jun 9, 10:38 AM UTC: Merged by the Graphite merge queue.