NO-JIRA: Consider kubectl version checks only from cli and cli-artifact images - #1656
Conversation
Currently, when we bump oc to newer k8s versions, our CI jobs are failing due to kubectl version mismatch error. The reason is that when we bump oc to newer kubectl(i.e. 1.29.0), cli and cli-artifact images manifest this version. On the other hand, other images in other operators have not-bumped kubectl version(i.e. 1.28.2). This PR only populates kubectl versions in cli and cli-artifact images(because they are the source of truth) but in addition to that this PR checks the other images as well to have a consistency with a rule about all images should match either kubectl version in cli, cli-artifact or match with each other (all versions in other images at least should equal to 1.28.2).
|
@ardaguclu: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
Spun up a cluster that contains a combination of this PR and #1656 and all tests passed; |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202401230706.p0.g64c6784.assembly.stream for distgit openshift-enterprise-cli. |
Currently, when we bump oc to newer k8s versions, our CI jobs are failing due to kubectl version mismatch error. The reason is that when we bump oc to newer kubectl(i.e. 1.29.0), cli and cli-artifact images manifest this version. On the other hand, other images in other operators have not-bumped kubectl version(i.e. 1.28.2).
This PR only populates kubectl versions in cli and cli-artifact images(because they are the source of truth) but in addition to that this PR checks the other images as well to have a consistency of a rule that all images should match either kubectl version in cli, cli-artifact or match with each other (all versions in other images at least should equal to 1.28.2).
valid image sets
invalid image sets
This PR is prerequisite of #1655