Repository navigation
Conversation
|
@devguyio: This pull request references HOSTEDCP-1767 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@devguyio: This pull request references HOSTEDCP-1767 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: devguyio The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold waiting for #4643 to be merged first |
openshift-ci
Bot
added
the
do-not-merge/hold
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| crclient "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| //go:embed prereqs-azure/* |
There was a problem hiding this comment.
Where those CRDs come from? I mean, for self-maintenance would we need to add a command to auto-generation/update of those CRDs in the Makefile, like we do with CAPI ones?
There was a problem hiding this comment.
That's a good idea! I wasn't aware we do that. I'll check it out.
|
/retest-required |
|
We make need to hold/rethink this PR a bit in light of RFE-6258. I don't know that we will need the Prometheus CRs now. We will still need the Routes CR though. |
Hypershift Operator needs some CRDs installed specifically on AKS clusters. Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
0c7cdf3 to
7ab677b
Compare
|
@devguyio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No longer needed. Can be revisited later if necessary. |
|
@devguyio: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Ah I thought we still needed this |
5 participants
What this PR does / why we need it:
Note
This PR is stacked on top of #4643 . It adds a single commit on top it and shouldn't be merged until #4643 is merged.
When installing the HO operator on an AKS cluster, there are a few CRDs the following CRDs need to be installed first:
This PR adds the capability to the install command of installing those CRDs when the
--managed-serviceis set toARO-HCP.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes HOSTEDCP-1767
Checklist