Skip to content

HOSTEDCP-1767: chore: organize install command for readability - #4643

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
devguyio:hostedcp-1767-aro-missing-crds
Sep 2, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
devguyio:hostedcp-1767-aro-missing-crds

Conversation

@devguyio

@devguyio devguyio commented Aug 30, 2024 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This is a preparation PR for HOSTEDCP-1767 that refactors the install command by breaking down the long hyperShiftOperatorManifests into smaller functions and making it focus on the high-level operations only.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot

openshift-ci-robot commented Aug 30, 2024 •

Copy link
Copy Markdown

@devguyio: This pull request references HOSTEDCP-1767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

This is a preparation PR for HOSTEDCP-1767 that refactors the install command by breaking down the long hyperShiftOperatorManifests into smaller functions and making it focus on the high-level operations only.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 30, 2024
@openshift-ci-robot

openshift-ci-robot commented Aug 30, 2024 •

Copy link
Copy Markdown

@devguyio: This pull request references HOSTEDCP-1767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

This is a preparation PR for HOSTEDCP-1767 that refactors the install command by breaking down the long hyperShiftOperatorManifests into smaller functions and making it focus on the high-level operations only.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from enxebre and hasueki August 30, 2024 07:59
@openshift-ci openshift-ci Bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Aug 30, 2024
@netlify

netlify Bot commented Aug 30, 2024

Copy link
Copy Markdown

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit ae3997d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66d17bdb8132bc0008b5cbc5
😎 Deploy Preview https://deploy-preview-4643--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@devguyio
devguyio force-pushed the hostedcp-1767-aro-missing-crds branch from ae3997d to bff24b6 Compare August 30, 2024 08:25
@bryan-cox

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Aug 30, 2024 •

Copy link
Copy Markdown

@bryan-cox: This pull request references HOSTEDCP-1767 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@csrwng

csrwng commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 64aabb8 and 2 for PR HEAD bff24b6 in total

@devguyio

devguyio commented Sep 2, 2024

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Sep 2, 2024 •

Copy link
Copy Markdown

@devguyio: This pull request references HOSTEDCP-1767 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:

This is a preparation PR for HOSTEDCP-1767 that refactors the install command by breaking down the long hyperShiftOperatorManifests into smaller functions and making it focus on the high-level operations only.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

@devguyio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 58ef572 into openshift:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants