Skip to content

CONSOLE-5031: Remove Firehose Component and Fix and Cleanup Impacted Types - #16096

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cajieh:remove-firehose-fix-cleanup-types
Mar 28, 2026
Merged

CONSOLE-5031: Remove Firehose Component and Fix and Cleanup Impacted Types#16096
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cajieh:remove-firehose-fix-cleanup-types

Conversation

@cajieh

@cajieh cajieh commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

### NOT READY FOR REVIEW

Waiting on PR to merge.

Summary by CodeRabbit

Release Notes

  • Refactor
    • Modernized internal Kubernetes resource management architecture by migrating from legacy Firehose-based patterns to watch-based resource types across the platform. This underlying update improves system reliability and prepares infrastructure for future enhancements.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 3, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references CONSOLE-5031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

NOT READY FOR REVIEW

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from spadgett and zhuje March 3, 2026 18:44
@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/helm Related to helm-plugin component/knative Related to knative-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 3, 2026
@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from 1680ec9 to 5b2a87b Compare March 4, 2026 13:46
@openshift-ci openshift-ci Bot added the kind/cypress Related to Cypress e2e integration testing label Mar 4, 2026
@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from 5b2a87b to 51a81d3 Compare March 4, 2026 15:43
@openshift-ci openshift-ci Bot added component/dashboard Related to dashboard component/metal3 Related to metal3-plugin component/sdk Related to console-plugin-sdk plugin-api-changed Categorizes a PR as containing plugin API changes labels Mar 4, 2026
@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch 3 times, most recently from 78d187e to 4e718b8 Compare March 6, 2026 20:40
@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from 4e718b8 to 3d41d3e Compare March 16, 2026 17:38
@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 24, 2026
@jhadvig

jhadvig commented Mar 24, 2026

Copy link
Copy Markdown
Member

/retest

jhadvig
jhadvig approved these changes Mar 24, 2026
View reviewed changes

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑 Thank you Cyril for making this happen.
... farewell to our old nemesis 🔥

/lgtm

Comment thread frontend/packages/console-dynamic-plugin-sdk/docs/console-extensions.md
| Name | Value Type | Optional | Description |
| ---- | ---------- | -------- | ----------- |
| `k8sResource` | `CodeRef<FirehoseResource & { isList: true; }>` | no | The utilization item to be replaced. |
| `k8sResource` | `CodeRef<WatchK8sResource & { prop: string; } & { isList: true; }>` | no | The utilization item to be replaced. |

@jhadvig jhadvig Mar 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the 4.22 changelog with this breaking change

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
TheRealJon
TheRealJon approved these changes Mar 24, 2026
View reviewed changes

@TheRealJon TheRealJon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread frontend/packages/console-shared/src/components/formik-fields/ResourceDropdownField.tsx Outdated
Comment on lines +15 to +30
dataSelector: string[] | number[] | symbol[];
resources: WatchK8sResultsObject<K8sResourceKind | K8sResourceKind[]>[];
showBadge?: boolean;
onLoad?: (items: ResourceDropdownItems) => void;
onChange?: ResourceDropdownProps['onChange'];
resourceFilter?: ResourceDropdownProps['resourceFilter'];
autoSelect?: ResourceDropdownProps['autoSelect'];
resourceFilter?: (resource: K8sResourceKind) => boolean;
autoSelect?: boolean;
placeholder?: string;
actionItems?: ResourceDropdownProps['actionItems'];
appendItems?: ResourceDropdownProps['appendItems'];
customResourceKey?: ResourceDropdownProps['customResourceKey'];
actionItems?: {
actionTitle: string;
actionKey: string;
}[];
appendItems?: ResourceDropdownItems;
customResourceKey?: (key: string, resource: K8sResourceKind) => string;
dataTest?: string;
menuClassName?: ResourceDropdownProps['menuClassName'];
menuClassName?: string;

@TheRealJon TheRealJon Mar 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, scope

Comment thread frontend/packages/dev-console/src/components/dropdown/SourceSecretDropdown.tsx Outdated
[props.namespace],
);

const watchedResources = useK8sWatchResources<{ secrets: SecretKind[] }>(watchSpec);

@TheRealJon TheRealJon Mar 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, if we only need to watch secrets, why use useK8sWatchResources instead of useK8sWatchResource?

@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from c8ba7bb to 2798f36 Compare March 25, 2026 02:04
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2026
@cajieh

cajieh commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/assign @yapei

@cajieh

cajieh commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

1 similar comment
@cajieh

cajieh commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@yapei

yapei commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

it looks like we have some issues loading Source secret on Import from Git page, a loading spinning icon is always showing and newly created secret are not shown in dropdown list

for other changes, no regression issues found

issues-loading-source-secret.mov

@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from 2798f36 to fad32d6 Compare March 26, 2026 11:12
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2026
@cajieh
cajieh force-pushed the remove-firehose-fix-cleanup-types branch from fad32d6 to 15b7e99 Compare March 26, 2026 11:47
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2026
@yapei

yapei commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

the reported issue has been fixed in latest code
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

the reported issue has been fixed in latest code
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh

cajieh commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff

logonoff commented Mar 27, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026
@openshift-ci

openshift-ci Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig, logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig jhadvig added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Mar 27, 2026
@logonoff logonoff mentioned this pull request Mar 27, 2026
Merged
@openshift-merge-bot
openshift-merge-bot Bot merged commit bfcb5bd into openshift:main Mar 28, 2026
8 checks passed
@vojtechszocs vojtechszocs mentioned this pull request Apr 22, 2026
Merged
@platex-rehor-bot platex-rehor-bot mentioned this pull request Aug 21, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@jhadvig jhadvig jhadvig approved these changes
@TheRealJon TheRealJon TheRealJon approved these changes
@spadgett spadgett Awaiting requested review from spadgett
@zhuje zhuje Awaiting requested review from zhuje

Assignees

@vojtechszocs vojtechszocs

@spadgett spadgett

@jhadvig jhadvig

@logonoff logonoff

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cajieh @openshift-ci-robot @jhadvig @yapei @logonoff @TheRealJon @vojtechszocs @spadgett