OCPBUGS-82473, CONSOLE-4512: Switch from legacy `render` to `createRoot` by logonoff · Pull Request #16202 · openshift/console

logonoff · 2026-03-26T13:17:01Z

This PR concludes the React 18 upgrade by switching the render function from the deprecated render to the concurrent createRoot. This affects all code rendered by React in Console, including all dynamic plugins.

This switch revealed several issues for us, several commits in this PR aim to address shortcomings in our React code revealed by createRoot.

Summary by CodeRabbit

Release Notes

New Features
- Added keyboard-accessible region landmarks to page content for improved navigation support.
Bug Fixes
- Improved perspective detection reliability for consistent developer perspective initialization.
- Enhanced test synchronization to reduce flaky test behaviors.
Tests
- Marked several integration tests as broken due to concurrent rendering compatibility issues (to be addressed separately).
- Updated test infrastructure with improved navigation helpers and selector robustness.
Refactor
- Migrated core rendering to React 18 createRoot API.
- Optimized state management patterns across multiple components using effect hooks.

openshift-ci-robot · 2026-03-26T13:17:06Z

@logonoff: This pull request references CONSOLE-4512 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-03-27T14:02:56Z

/label px-approved
/label docs-approved

jhadvig

Claude coded my way though the cypress failing tests. PTAL

openshift-ci-robot · 2026-03-28T10:57:16Z

@logonoff: This pull request references CONSOLE-4512 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR concludes the React 18 upgrade by switching the render function from the deprecated render to the concurrent createRoot. This affects all code rendered by React in Console, including all dynamic plugins.

This switch revealed several issues for us, several commits in this PR aim to address shortcomings in our React code revealed by createRoot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig · 2026-04-10T16:33:11Z

deletes the resource instance: Kubernetes resource CRUD operations Role deletes the resource instance

logonoff · 2026-04-10T16:39:44Z

/retest

logonoff · 2026-04-10T16:52:22Z

/verified by @logonoff

the following scenarios have been run to cover skipped tests:

locally: the following tests have passed (at least once): add-flow-ci, helm-release, topology-ci
on a cluster: installed web terminal operator, installed operators page and operator details page works on first glance
- minor issue with navigation buttons in operator details page tab list appearing for a split second, then animating away - this appears to be a pre-existing issue that was only made more obvious because PatternFly tab microanimations work
- web terminal works as expected - timeout dropdown, xterm, terminal connection closed and reconnect, restore/minimize
on a cluster: used import from git form through +Add to create a serverless deployment from a container image and it appears to work fine - i am able to access the deployed container

openshift-ci-robot · 2026-04-10T16:52:34Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

/verified by @logonoff

the following scenarios have been run to cover skipped tests:

locally: the following tests have passed (at least once): add-flow-ci, helm-release, topology-ci

on a cluster: installed web terminal operator, installed operators page and operator details page works on first glance

minor issue with navigation buttons in operator details page tab list appearing for a split second, then animating away - this appears to be a pre-existing issue that was only made more obvious because PatternFly tab microanimations work

web terminal works as expected - timeout dropdown, xterm, terminal connection closed and reconnect, restore/minimize

on a cluster: used import from git from through +Add to create a serverless deployment from a container image and it appears to work fine - i am able to access the deployed container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2026-04-10T16:58:06Z

+  const navigateRef = useRef(navigate);
+  navigateRef.current = navigate;
+  const lastNamespaceRef = useRef(lastNamespace);
+  lastNamespaceRef.current = lastNamespace;


In future we may consider improving this code to avoid having both

const [activeNamespace, setActiveNamespace] = useState<string>(urlNamespace);

and

const activeNamespaceRef = useRef(activeNamespace);

We currently need the ref to avoid overriding react-hooks/exhaustive-deps rule, if I understand it correctly.

vojtechszocs · 2026-04-10T17:04:52Z

    .contains(path[0])
    .click(); // open top, expandable menu
+  // eslint-disable-next-line cypress/no-unnecessary-waiting
+  cy.wait(500); // wait for animation


Is there a way to disable PatternFly visual animations for the purpose of e2e test runs?

There should be some built in cypress way to wait for animations but I need to figure out why it's not working now

vojtechszocs · 2026-04-10T17:12:58Z

              And user will see "Samples" option
              And user will see Import YAML, Upload JAR file under From Local Machine section

+        # Disabled due to createRoot concurrent rendering failures (OCPBUGS-82505)


We should create an issue to handle disabled e2e test scenarios in future.

All disabled e2e scenarios have a related OCPBUGS to reneable them

vojtechszocs · 2026-04-10T17:17:08Z

/lgtm

jhadvig · 2026-04-10T20:20:30Z

/retest

logonoff · 2026-04-10T23:18:45Z

/retest

Temporarily disable several flaky integration tests that fail with createRoot concurrent rendering errors. Added @broken-test tag to multiple feature files and converted affected Cypress suites to xdescribe to skip them in CI. Files affected span dev-console, helm-plugin, knative-plugin, topology, webterminal-plugin, operator-lifecycle-manager, and cluster-settings tests (OCPBUGS-82504 through OCPBUGS-82513).

logonoff · 2026-04-10T23:28:36Z

disabled the entire suite in hopes of less flaky ci

/verified by @logonoff

openshift-ci-robot · 2026-04-10T23:28:45Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

disabled the entire suite in hopes of less flaky ci

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Leo6Leo · 2026-04-11T02:55:08Z

/lgtm

openshift-ci · 2026-04-11T02:55:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-04-11T06:30:38Z

/retest-required

Remaining retests: 0 against base HEAD fb24786 and 2 for PR HEAD c18637a in total

logonoff · 2026-04-11T12:10:28Z

/test all

openshift-ci · 2026-04-11T15:03:47Z

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-04-11T15:07:43Z

@logonoff: Jira Issue Verification Checks: Jira Issue OCPBUGS-82473
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-82473 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This PR concludes the React 18 upgrade by switching the render function from the deprecated render to the concurrent createRoot. This affects all code rendered by React in Console, including all dynamic plugins.

This switch revealed several issues for us, several commits in this PR aim to address shortcomings in our React code revealed by createRoot.

Summary by CodeRabbit

Release Notes

New Features

Added keyboard-accessible region landmarks to page content for improved navigation support.

Bug Fixes

Improved perspective detection reliability for consistent developer perspective initialization.

Enhanced test synchronization to reduce flaky test behaviors.

Tests

Marked several integration tests as broken due to concurrent rendering compatibility issues (to be addressed separately).

Updated test infrastructure with improved navigation helpers and selector robustness.

Refactor

Migrated core rendering to React 18 createRoot API.

Optimized state management patterns across multiple components using effect hooks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-12T09:45:03Z

Fix included in release 4.22.0-0.nightly-2026-04-12-005049

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2026

openshift-ci Bot requested review from rawagner and spadgett March 26, 2026 13:20

openshift-ci Bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 27, 2026

jhadvig reviewed Mar 27, 2026

View reviewed changes

Comment thread frontend/packages/integration-tests-cypress/views/secret.ts Outdated

Comment thread frontend/packages/integration-tests/tests/crud/roles-rolebindings.cy.ts

logonoff force-pushed the CONSOLE-4512-createRoot branch 3 times, most recently from 032c399 to c342860 Compare March 28, 2026 10:57

logonoff force-pushed the CONSOLE-4512-createRoot branch 2 times, most recently from d27c60a to 14be8c2 Compare March 31, 2026 14:12

openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026

logonoff force-pushed the CONSOLE-4512-createRoot branch 3 times, most recently from 4eadceb to 4354ae3 Compare April 2, 2026 03:01

openshift-ci Bot added the component/dev-console Related to dev-console label Apr 2, 2026

logonoff force-pushed the CONSOLE-4512-createRoot branch 2 times, most recently from 299f66a to 4cce42b Compare April 7, 2026 15:27

openshift-ci Bot added the component/helm Related to helm-plugin label Apr 7, 2026

logonoff force-pushed the CONSOLE-4512-createRoot branch 2 times, most recently from 39cc9ba to 51de883 Compare April 7, 2026 18:56

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 10, 2026

vojtechszocs approved these changes Apr 10, 2026

View reviewed changes

openshift-ci Bot assigned vojtechszocs Apr 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026

logonoff force-pushed the CONSOLE-4512-createRoot branch from 88ff6bb to c18637a Compare April 10, 2026 23:28

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Apr 10, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 10, 2026

openshift-ci Bot assigned Leo6Leo Apr 11, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2026

openshift-merge-bot Bot merged commit 982f7c1 into openshift:main Apr 11, 2026
8 checks passed

logonoff deleted the CONSOLE-4512-createRoot branch April 11, 2026 15:23

sg00dwin mentioned this pull request Apr 15, 2026

OCPBUGS-82512: Fix knative e2e test failures caused by createRoot timing #16289

Merged

3 tasks

Uh oh!

Conversation

logonoff commented Mar 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

openshift-ci-robot commented Mar 26, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff commented Mar 27, 2026

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhadvig commented Apr 10, 2026

Uh oh!

logonoff commented Apr 10, 2026

Uh oh!

logonoff commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 10, 2026

Uh oh!

vojtechszocs Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

logonoff Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

logonoff Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

vojtechszocs commented Apr 10, 2026

Uh oh!

jhadvig commented Apr 10, 2026

Uh oh!

logonoff commented Apr 10, 2026

Uh oh!

logonoff commented Apr 10, 2026

Uh oh!

openshift-ci-robot commented Apr 10, 2026

Uh oh!

Leo6Leo commented Apr 11, 2026

Uh oh!

openshift-ci Bot commented Apr 11, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 11, 2026

Uh oh!

logonoff commented Apr 11, 2026

Uh oh!

openshift-ci Bot commented Apr 11, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2026

Summary by CodeRabbit

Release Notes

Uh oh!

openshift-merge-robot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

logonoff commented Mar 26, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Mar 26, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 28, 2026 •

edited by openshift-ci Bot

Loading

logonoff commented Apr 10, 2026 •

edited

Loading