CONSOLE-5027: Refactor public/ Directory Components to useK8sWatchResource(s) by cajieh · Pull Request #15954 · openshift/console

cajieh · 2026-01-28T15:52:28Z

This change migrates components dependent on the Firehose component to useK8sWatchResource(s). The removal of the Firehose component and the cleanup of associated types will be covered in follow-on work.

openshift-ci-robot · 2026-01-28T15:52:32Z

@cajieh: This pull request references CONSOLE-5027 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

NOT READY FOR REVIEW

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-28T15:52:38Z

📝 Walkthrough

Walkthrough

Replaces Firehose-based data provisioning with hook-based Kubernetes watchers (useK8sWatchResource / useK8sWatchResources) across the console frontend. Components now pass {data, loaded, loadError} objects, update prop types, and remove Firehose/flags HOCs; several components gain or adjust exports/signatures accordingly.

Cohort / File(s)	Summary
Global locales `frontend/packages/console-app/locales/en/console-app.json`, `frontend/packages/operator-lifecycle-manager-v1/locales/en/olm-v1.json`, `frontend/public/locales/en/public.json`	Added/removed small translation keys; minor locale edits.
Core hook migrations (terminal/container/edit-yaml/etc.) `frontend/packages/console-app/src/components/nodes/NodeTerminal.tsx`, `frontend/public/components/container.tsx`, `frontend/public/components/create-yaml.tsx`, `frontend/public/components/edit-yaml.tsx`, `frontend/public/components/instantiate-template.tsx`	Replaced Firehose wrappers with useK8sWatchResource/useK8sWatchResources; components now receive obj with data, loaded, loadError; added loading/error branches.
RBAC & bindings `frontend/public/components/RBAC/bindings.tsx`	Moved from Firehose to watch hooks; changed row/obj shape handling (use row.obj, optional chaining); BindingLoadingWrapper props and related types updated.
Cluster / Monitoring / Storage components `frontend/public/components/cluster-settings/cluster-settings.tsx`, `frontend/public/components/monitoring/.../alertmanager-*.tsx`, `frontend/public/components/storage-class-form.tsx`, `frontend/public/components/utils/storage-class-dropdown.tsx`	Switched data sourcing to k8s-watch hooks; updated props/types to WatchK8sResultsObject and passed loaded/loadError through.
Command-line & notifier `frontend/public/components/command-line-tools.tsx`, `frontend/public/components/console-notifier.tsx`	Removed connectToFlags/Firehose HOCs; added useFlag/useK8sWatchResource hooks; updated public prop shapes (CommandLineToolsProps) and component signatures.
Factory / list page / horizontal nav `frontend/public/components/factory/.../details.tsx`, `frontend/public/components/factory/list-page.tsx`, `frontend/public/components/utils/horizontal-nav.tsx`	Introduced watchedResources props and useK8sWatchResources; adjusted ListPageWrapper/MultiListPage APIs and AsyncComponent create flag in horizontal-nav.
CronJobs & templates `frontend/public/components/cron-job.tsx`, `frontend/public/components/instantiate-template.tsx`	Exposed CronJobPodsComponent/CronJobJobsComponent as FC exports; replaced Firehose with hook-based resource watching and flattened results.
Forms & receivers `frontend/public/components/monitoring/receiver-forms/alert-manager-receiver-forms.tsx`, `frontend/public/components/storage-class-form.tsx`, `frontend/public/components/namespace-bar.tsx`, `frontend/public/components/utils/list-dropdown.tsx`	Hook-based data fetching replacing Firehose; props/types updated (namespace/resources typed as WatchK8sResultsObject); new internal prop types added where applicable.
Utilities & dropdowns `frontend/public/components/utils/list-dropdown.tsx`, `frontend/public/components/utils/storage-class-dropdown.tsx`	Internal prop/type changes to accept watchedResources; compute loaded/loadError from watch results; removed Firehose wiring.
Binding actions & other small fixes `frontend/packages/console-app/src/actions/hooks/useBindingActions.ts`, `frontend/packages/operator-lifecycle-manager-v1/src/components/cluster-extension/ServiceAccountDropdown.tsx`	Smaller internal robustness fixes (nullish destructuring, optional chaining) and i18n key namespace change for placeholder.
Tests `frontend/packages/helm-plugin/.../HelmReleaseResources.spec.tsx`, `frontend/public/components/__tests__/.spec.tsx`, `frontend/public/components/factory/__tests__/`	Updated mocks and assertions to use k8s-watch-hook mocks (useK8sWatchResource(s)) instead of Firehose mocks; adjusted expectations accordingly.
Other assorted files under `frontend/public/components/...` and `frontend/packages/...` (many diffs)	Widespread removal of Firehose imports, additions of k8s-watch-hook imports, propagation of loaded/loadError and minor render-guard updates across many components.

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: refactoring public/ directory components to use useK8sWatchResource(s) instead of Firehose, with a valid Jira ticket reference (CONSOLE-5027).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-02-04T11:00:31Z

@cajieh: This pull request references CONSOLE-5027 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-02-05T19:53:55Z

-    const resources = flags[FLAGS.CONSOLE_YAML_SAMPLE]
-      ? [
-          {
+    const watchResources = flags[FLAGS.CONSOLE_YAML_SAMPLE]


for EditYAML we can actually simplify this even further by using useFlag and moving this into the main EditYAML component. Then we do not need EditYAML_ and WithFlagProps and all that other stuff

cajieh · 2026-02-06T18:38:12Z

-    isList: false,
-    prop: 'obj',
-  };
+  const objResource = useMemo<FirehoseResource>(


Deferring to the Firehose Type migration effort.

cajieh · 2026-03-19T12:20:20Z

/test e2e-gcp-console

cajieh · 2026-03-19T15:05:46Z

/test e2e-gcp-console

cajieh · 2026-03-19T15:17:39Z

/test e2e-gcp-console

cajieh · 2026-03-19T17:10:32Z

/test e2e-gcp-console

cajieh · 2026-03-19T17:12:11Z

/test frontend

cajieh · 2026-03-20T00:57:22Z

/test e2e-gcp-console

cajieh · 2026-03-20T11:07:30Z

/retest

cajieh · 2026-03-21T09:19:17Z

/test e2e-gcp-console

cajieh · 2026-03-21T18:09:38Z

/restest

cajieh · 2026-03-21T18:10:02Z

/retest

cajieh · 2026-03-22T06:13:45Z

/test e2e-gcp-console

cajieh · 2026-03-22T19:58:46Z

/test all

logonoff · 2026-03-23T01:19:47Z

+    ],
+    [resourcePageExtensions, kindObj],
+  );
+


i'm confused by this addition because i removed this in #16043

Oops, a rebase artifact! 😅 Reverted!
Just trying a brute-force approach to resolve these persistent E2E failures.
Will review the changes thoroughly once the tests are passing.

cajieh · 2026-03-22T21:55:07Z

+
+  const pluginPages = useMemo(
+    () => [
+      /** @deprecated -- if there is a bug here, encourage `console.tab/horizontalNav` usage instead */


TODO: Remove it.

cajieh · 2026-03-23T10:09:37Z

+    ],
+    [resourcePageExtensions, kindObj],
+  );
+


Oops, a rebase artifact! 😅 Reverted!
Just trying a brute-force approach to resolve these persistent E2E failures.
Will review the changes thoroughly once the tests are passing.

cajieh · 2026-03-23T17:54:12Z

Hmm, the last run failed with a different error than the previous ones; however, it appears to be related to an infra issue. As we discussed, I will skip these specific tests for now, open a Jira ticket to track the flakes, and re-test.
cc: @jhadvig @logonoff

Made-with: Cursor

jhadvig · 2026-03-23T19:06:29Z

overriding due to flakiness, skipping deprecated-operator-warnings.cy.ts and operator-install-global.cy.ts

/override ci/prow/e2e-gcp-console
/lgtm
/verify later @yapei

openshift-ci · 2026-03-23T19:07:27Z

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

overriding due to flakiness.
Also we are skipping deprecated-operator-warnings.cy.ts and operator-install-global.cy.ts

/override ci/prow/e2e-gcp-console
/lgtm
/verify later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jhadvig · 2026-03-23T19:09:21Z

/lgtm
/verified later @yapei

openshift-ci-robot · 2026-03-23T19:09:33Z

@jhadvig: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/lgtm
/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-23T19:09:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig, jseseCCS, krishagarwal278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [cajieh,jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-03-23T19:19:34Z

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2026

openshift-ci Bot requested review from Leo6Leo and jgbernalp January 28, 2026 15:53

openshift-ci Bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2026

cajieh force-pushed the migrate-firehose-to-hooks branch from ed33b09 to 7b7d0f8 Compare February 3, 2026 14:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026

cajieh force-pushed the migrate-firehose-to-hooks branch from 7b7d0f8 to 5f6e3ed Compare February 4, 2026 10:52

cajieh force-pushed the migrate-firehose-to-hooks branch 4 times, most recently from 7dca8dc to b879d3d Compare February 4, 2026 22:42

logonoff reviewed Feb 5, 2026

View reviewed changes

cajieh force-pushed the migrate-firehose-to-hooks branch from b879d3d to 7db7e98 Compare February 6, 2026 18:28

cajieh commented Feb 6, 2026

View reviewed changes

cajieh force-pushed the migrate-firehose-to-hooks branch from 7db7e98 to 8d8177e Compare February 9, 2026 14:37

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2026

cajieh force-pushed the migrate-firehose-to-hooks branch from 8d8177e to 935611e Compare February 9, 2026 15:05

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2026

cajieh force-pushed the migrate-firehose-to-hooks branch 2 times, most recently from 9abced3 to c81bc77 Compare February 9, 2026 18:36

cajieh changed the title ~~[WIP] CONSOLE-5027: Refactor public/ Directory Components to useK8sWatchResource(s)~~ CONSOLE-5027: Refactor public/ Directory Components to useK8sWatchResource(s) Feb 9, 2026

openshift-ci Bot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 9, 2026

logonoff mentioned this pull request Mar 20, 2026

CONSOLE-5073: Update redux-related packages to latest #16087

Merged

logonoff reviewed Mar 23, 2026

View reviewed changes

cajieh commented Mar 23, 2026

View reviewed changes

cajieh mentioned this pull request Mar 23, 2026

CONSOLE-5031: Remove Firehose Component and Fix and Cleanup Impacted Types #16096

Merged

Refactor public/ Directory Components to useK8sWatchResource(s)

70de9e5

Made-with: Cursor

coderabbitai Bot mentioned this pull request Jul 8, 2026

CNV-90382: remove jsdoc rule and add promise rule kubevirt-ui/kubevirt-plugin#4208

Closed

coderabbitai Bot mentioned this pull request Jul 27, 2026

CNV-74205: user default labels section kubevirt-ui/kubevirt-plugin#4425

Merged

This was referenced Aug 5, 2026

Resolves: MTV-6285 | Fix setState-in-useEffect and enable rule kubev2v/forklift-console-plugin#2650

Merged

CNV-92611: [release-4.18] Non-admin users trigger excessive per-namespace watches kubevirt-ui/kubevirt-plugin#4551

Merged

This was referenced Aug 19, 2026

CNV-90382: add eslint react linter part 2 kubevirt-ui/kubevirt-plugin#4565

Merged

Resolves: MTV-6277 | Enable no-unsafe-assignment for src kubev2v/forklift-console-plugin#2723

Merged

Uh oh!

Conversation

cajieh commented Jan 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 28, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

NOT READY FOR REVIEW

Uh oh!

coderabbitai Bot commented Jan 28, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci-robot commented Feb 4, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logonoff Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh commented Mar 19, 2026

Uh oh!

cajieh commented Mar 19, 2026

Uh oh!

cajieh commented Mar 19, 2026

Uh oh!

cajieh commented Mar 19, 2026

Uh oh!

cajieh commented Mar 19, 2026

Uh oh!

cajieh commented Mar 20, 2026

Uh oh!

cajieh commented Mar 20, 2026

Uh oh!

cajieh commented Mar 21, 2026

Uh oh!

cajieh commented Mar 21, 2026

Uh oh!

cajieh commented Mar 21, 2026

Uh oh!

cajieh commented Mar 22, 2026

Uh oh!

cajieh commented Mar 22, 2026

Uh oh!

logonoff Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cajieh commented Mar 23, 2026

Uh oh!

jhadvig commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

jhadvig commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cajieh commented Jan 28, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jan 28, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jan 28, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 4, 2026 •

edited by openshift-ci Bot

Loading

jhadvig commented Mar 23, 2026 •

edited

Loading