Skip to content

OCPBUGS-114428: Update build-machinery-go vendor dependency - #991

Merged
sdodson merged 1 commit into
openshift:masterfrom
redhat-chai-bot:update-build-machinery-go
Sep 11, 2026
Merged

sdodson merged 1 commit into
openshift:masterfrom
redhat-chai-bot:update-build-machinery-go

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Summary by CodeRabbit

  • Chores
    • Updated an internal build tooling dependency to a newer version.

@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Sep 10, 2026
@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: dfc2b0f4-5042-485b-85bc-736b6ef19461

📥 Commits

Reviewing files that changed from the base of the PR and between e1a4b28 and 1e7b021.

⛔ Files ignored due to path filters (12)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/build-machinery-go/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/AGENTS.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/ARCHITECTURE.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/CLAUDE.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/OWNERS is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/OWNERS_ALIASES is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/lib/golang.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/build-machinery-go/make/targets/golang/version.mk is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the github.com/openshift/build-machinery-go dependency in go.mod to a newer pseudo-version. No other module settings or dependencies changed.

Changes

Build machinery dependency

Layer / File(s) Summary
Update build-machinery-go requirement
go.mod
The dependency changed from v0.0.0-20251023084048-5d77c1a5e5af to v0.0.0-20260902143904-520f675c892b.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: p0lyn0mial, bertinatto, gangwgr

Merge Risk: ⚪ Minimal · up to 1e7b0

The dependency version update has no supported merge-blocking risk in the reviewed change.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the tracked issue and accurately summarizes the main change: updating the build-machinery-go vendor dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes dependency metadata and vendored build-machinery makefiles and documentation. The authoritative diff contains no Ginkgo test files, test-title calls, or added or removed Describe, `Co…
Test Structure And Quality ✅ Passed PASS: The authoritative PR diff changes only go.mod/go.sum, vendor metadata, documentation, and Makefile fragments. It changes no *_test.go files, Go source files, or Ginkgo constructs. Therefore the …
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests or test source files. The authoritative diff changes go.mod, go.sum, vendor/modules.txt, and vendored build-machinery-go metadata/build makefiles only. …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull-request diff adds no Go files or test paths. It changes only go.mod, go.sum, vendor/modules.txt, and vendored build-machinery-go documentation/build metadata. No added It(), Describe(),…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The review-scoped diff changes only Go module metadata and vendored build-machinery-go files. It adds or modifies no deployment manifests, operator code, controllers, or scheduling configuration…
Ote Binary Stdout Contract ✅ Passed PASS: The PR changes no Go source files and adds no process-level stdout writes. The changed vendored files contain only dependency metadata, documentation, and Make fragments. The unchanged OTE main …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds no Ginkgo e2e tests or Go test files. The authoritative diff changes only dependency metadata and vendored build-machinery-go documentation and Makefiles. No new It, Describe, Co…
No-Weak-Crypto ✅ Passed The pull request changes only dependency metadata, documentation, and Make fragments. The authoritative diff contains no changed Go or other source files, and no added use of MD5, SHA-1, DES, RC4, 3DE…
Container-Privileges ✅ Passed The pull-request diff changes dependency metadata and vendored build-machinery files only. It adds no container or Kubernetes manifest. Searches of added content found no privileged, hostPID, hostNetw…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds no logging of sensitive data. The only new runtime output is from the vendored Go-version verification target, which reports fixed mismatch text, source labels, and extracted MAJ…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Summary by CodeRabbit

  • Chores
  • Updated an internal build tooling dependency to a newer version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/retest


AI-generated. Review for accuracy.

@sdodson

sdodson commented Sep 11, 2026

Copy link
Copy Markdown
Member

/test images

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson

sdodson commented Sep 11, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-5.0 release-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@sdodson: once the present PR merges, I will cherry-pick it on top of release-5.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-5.0 release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson

sdodson commented Sep 11, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-5.0 release-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@sdodson: once the present PR merges, I will cherry-pick it on top of release-5.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-5.0 release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
sdodson merged commit e64601f into openshift:master Sep 11, 2026
8 of 15 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Jira Issue OCPBUGS-114428: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-114428 has not been moved to the MODIFIED state.

Details

In response to this:

Summary

Update github.com/openshift/build-machinery-go vendor dependency to v0.0.0-20260902143904-520f675c892b.

Changes

  • Updated go.mod with the latest build-machinery-go version
  • Ran go mod tidy
  • Ran go mod vendor to update the vendored copy

Related

  • OCPBUGS-114428: Bump golang builder to 1.26 and protobuf for 5.1 OCP CI and Nightlies

AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Summary by CodeRabbit

  • Chores
  • Updated an internal build tooling dependency to a newer version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@sdodson: new pull request created: #998

Details

In response to this:

/cherry-pick release-5.0 release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-09-13-143601

This was referenced Sep 24, 2026
@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-09-27-133659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants