Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #1471

Merged
sdodson merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Sep 24, 2026
Merged

sdodson merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an indirect Protocol Buffers dependency to a newer patch version.

Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 0deeb4d5-433f-446a-ba55-45905f008f09

📥 Commits

Reviewing files that changed from the base of the PR and between 697ea93 and a6ec7bc.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum, !go.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the indirect google.golang.org/protobuf dependency from v1.36.10 to v1.36.12 in go.mod.

Changes

Protobuf dependency update

Layer / File(s) Summary
Protobuf module requirement update
go.mod
The indirect google.golang.org/protobuf requirement changes from v1.36.10 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to a6ec7

The protobuf dependency update is limited in scope, with no unresolved correctness, integration, or supply-chain risk identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the protobuf dependency update to v1.36.12 and includes the related issue reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only dependency metadata: go.mod updates google.golang.org/protobuf from v1.36.10 to v1.36.12, and go.sum adds checksums. It changes no test files or test titles, …
Test Structure And Quality ✅ Passed PASS: The reviewed range changes only go.mod and go.sum. The patch updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds its checksums. It changes no Ginkgo test code, so the stated te…
Microshift Test Compatibility ✅ Passed PASS: The authoritative pull-request diff changes only go.mod and go.sum. It adds no Ginkgo e2e tests or test code, so the MicroShift API and feature compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The reviewed range changes only go.mod and go.sum. It adds no Ginkgo tests or other Go test files, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The authoritative PR diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the corresponding checksums. No deployment manifests, ope…
Ote Binary Stdout Contract ✅ Passed The pull request changes only go.mod and go.sum. The code diff contains no Go, OTE entry-point, suite setup, or stdout-writing changes. The sole behavioral dependency change updates the indirect googl…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The authoritative PR diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksums. No Go files or Ginkgo e2e tests changed…
No-Weak-Crypto ✅ Passed PASS. The review range changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksums. No changed line contains MD5, SHA1, DES, R…
Container-Privileges ✅ Passed PASS. The pull request changes only go.mod and go.sum. The patch updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds its checksums. It introduces no container or Kubernetes manifest …
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds checksum entries. It adds no source files, logging calls, or sensitive-d…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@Prashanth684 Prashanth684 removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 17, 2026
@Prashanth684

Copy link
Copy Markdown
Contributor

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agnostic-operator
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-techpreview-serial-1of3
/test e2e-agnostic-ovn-techpreview-serial-2of3
/test e2e-agnostic-ovn-techpreview-serial-3of3
/test e2e-agnostic-ovn-upgrade-into-change
/test e2e-agnostic-ovn-upgrade-out-of-change
/test e2e-aws-ovn-techpreview
/test e2e-hypershift
/test e2e-hypershift-conformance

@Prashanth684

Copy link
Copy Markdown
Contributor

/cc @wking @DavidHurta could this be approved please?

@Prashanth684

Copy link
Copy Markdown
Contributor

/retest

@Prashanth684 Prashanth684 added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agnostic-operator
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-techpreview-serial-1of3
/test e2e-agnostic-ovn-techpreview-serial-2of3
/test e2e-agnostic-ovn-techpreview-serial-3of3
/test e2e-agnostic-ovn-upgrade-into-change
/test e2e-agnostic-ovn-upgrade-out-of-change
/test e2e-aws-ovn-techpreview
/test e2e-hypershift
/test e2e-hypershift-conformance

@Prashanth684 Prashanth684 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2026
@Prashanth684

Copy link
Copy Markdown
Contributor

/verified by ci

@Prashanth684

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Prashanth684: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
sdodson merged commit d811c67 into openshift:main Sep 24, 2026
12 of 19 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Jira Issue OCPBUGS-114428: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-114428 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
  • Updated an indirect Protocol Buffers dependency to a newer patch version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-09-27-133659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants