Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #92

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Sep 24, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Bump google.golang.org/protobuf to v1.36.12 in the payload dependency module(s). This is a protobuf-only change; required module/vendor metadata is included, with no builder or unrelated changes. Validation completed.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an indirect Protocol Buffers dependency to a newer patch version.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 57f879a6-0cc6-4e28-a9e8-4de151420859

📥 Commits

Reviewing files that changed from the base of the PR and between ba3de3b and 069741e.

⛔ Files ignored due to path filters (13)
  • exporter/go.sum is excluded by !**/*.sum
  • exporter/vendor/google.golang.org/protobuf/encoding/protodelim/protodelim.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/encoding/prototext/decode.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/internal/descfmt/stringer.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/internal/editiondefaults/editions_defaults.binpb is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/internal/encoding/defval/default.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/internal/version/version.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/reflect/protoreflect/source_gen.go is excluded by !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.go is excluded by !**/*.pb.go, !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/types/known/anypb/any.pb.go is excluded by !**/*.pb.go, !**/vendor/**
  • exporter/vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.go is excluded by !**/*.pb.go, !**/vendor/**
  • exporter/vendor/modules.txt is excluded by !**/vendor/**
📒 Files selected for processing (1)
  • exporter/go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The exporter module updates its indirect google.golang.org/protobuf dependency from v1.36.11 to v1.36.12.

Changes

Protobuf dependency update

Layer / File(s) Summary
Update protobuf dependency
exporter/go.mod
The indirect google.golang.org/protobuf dependency changes from v1.36.11 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 06974

The dependency update is limited in scope and has no identified merge-blocking issue.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating google.golang.org/protobuf to v1.36.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only protobuf module metadata and vendored protobuf source files. The authoritative diff contains no test files, Ginkgo title calls, or added dynamic test names. Therefo…
Test Structure And Quality ✅ Passed The check is not applicable. The authoritative PR diff changes only dependency metadata and vendored google.golang.org/protobuf files. It changes no *_test.go files, no test directories, and no Ginkgo…
Microshift Test Compatibility ✅ Passed The check is not triggered. The pull request changes only exporter dependency metadata and vendored google.golang.org/protobuf files. The reviewed diff adds no Ginkgo tests, test files, or test declar…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The scoped pull-request diff changes only exporter dependency metadata and vendored google.golang.org/protobuf v1.36.12 files. It adds no Ginkgo e2e tests or other tests that could assume multip…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only exporter dependency metadata and vendored google.golang.org/protobuf files. The authoritative diff contains no deployment manifests, operator/controller code, or sc…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only protobuf module metadata and vendored protobuf sources. It adds no main(), TestMain(), Ginkgo suite setup, klog, log, fmt.Print*, os.Stdout, or other stdout sink. T…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request adds no Ginkgo e2e tests. The authoritative diff changes exporter/go.mod, go.sum, vendor metadata, and vendored google.golang.org/protobuf source files for the v1.36.12 u…
No-Weak-Crypto ✅ Passed The pull request only bumps google.golang.org/protobuf from v1.36.11 to v1.36.12 and updates vendored protobuf code and metadata. The code changes add parsing limits, descriptor fields, formatting c…
Container-Privileges ✅ Passed PASS. The review-scoped diff changes only exporter/go.mod, exporter/go.sum, protobuf vendor Go/binary files, and vendor/modules.txt. It adds no container or Kubernetes manifest. The privilege-related …
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR changes only the protobuf dependency metadata and vendored protobuf implementation. The changed Go files add no logging calls or logging packages. The added output is limited to protobuf …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12 in the payload dependency module(s). This is a protobuf-only change; required module/vendor metadata is included, with no builder or unrelated changes. Validation completed.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@jmesnil

jmesnil commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2026
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws
/test e2e-tests

@Prashanth684 Prashanth684 removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 17, 2026
@Prashanth684

Copy link
Copy Markdown

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Prashanth684: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Prashanth684

Copy link
Copy Markdown

@jmesnil could you approve this as well please?

@openshift-ci

openshift-ci Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmesnil, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026
@Prashanth684 Prashanth684 added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 23, 2026
@Prashanth684

Copy link
Copy Markdown

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws
/test e2e-tests

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 23a0d85 into openshift:main Sep 24, 2026
8 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: Jira Issue OCPBUGS-114428: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-114428 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12 in the payload dependency module(s). This is a protobuf-only change; required module/vendor metadata is included, with no builder or unrelated changes. Validation completed.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
  • Updated an indirect Protocol Buffers dependency to a newer patch version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown

Fix included in release 5.1.0-0.nightly-2026-09-27-133659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants